On Sun, Jul 24, 2011 at 10:58:00AM -0600, Anthony J. Bentley wrote:
> On Fri, Jul 1, 2011 at 4:16 AM, Stuart Henderson <s...@spacehopper.org> wrote:
> > On 2011-06-27, Anthony J. Bentley <anthonyjbent...@gmail.com> wrote:
> >> pkg/DESCR:
> >> DeSmuME is a Nintendo DS emulator under GNU GPL. It can boot homebrew
> >> and games, some of which are playable.
> >>
> >> Runs quite well on amd64/i386. The port is not really finished
> >> though... it mysteriously fails to build if graphics/agg is installed.
> >
> > diff below relative to your tgz:
> >
> > - avoid conflict with ALIGN macro in <machine/param.h> (this should
> > go upstream if possible)
> 
> Thanks, it's fixed upstream.
> 
> > - add proper deps for xdg desktop files and regen PLIST
> > - add wantlib/lib dep for agg
> > - drop unneeded patch to NDSSystem.h
> > - sync wantlib
> > - adjust Makefile closer to Makefile.template
> > - more accurate license marker (source files say "GPL v2 or newer")
> 
> All look good.
> 
> > builds/packages ok but otherwise untested.
> 
> Works on i386.

It'd be good to test it on other archs, esp amd64 or ppc, even sparc64,
since there might be alignment issues.. i'll give it a shot on ppc.

> > pkg/DESCR could do with adjusting, it doesn't read very clearly
> > at present.
> 
> Here is a slightly better one from FreeBSD:
> 
> DeSmuME is a Nintendo DS emulator.
> 
> It supports many homebrew NDS rom demos as well as a handful of wireless
> multiboot demo NDS roms. It also runs DSLinux, the port of Linux to the
> Nintendo DS.
> 
> ok?

patches/patch-src_NDSSystem_h is empty.. is that intended ?

Landry

Reply via email to