One more request Wen, if you could add: REGRESS_DEPENDS= devel/p5-Test-Pod
that would be look good to me. All regress tests pass. Regards, Mikolaj On Sat, Aug 20, 2011 at 04:40:26PM +0800, wen heping wrote: > Revised again again. > > Comments? > > wen > > 2011/8/19 Mikolaj Kucharski <miko...@kucharski.name>: > > On Fri, Aug 19, 2011 at 10:29:17PM +0800, wen heping wrote: > >> Revised again. > >> > >> Comments? > >> > >> wen > > > > Much better, but you still didn't include @pkgpath marker in PLIST, that > > should look like: > > > > @pkgpath textproc/p5-LibXML-Common > > > > also, personally I would bump WANTLIB for xml2 to the same value like in > > textproc/p5-LibXML-Common so: > > > > WANTLIB= m z xml2>=7 > > > > but it's probably not stricly needed at this stage, as in ports version > > of libxml has so major number set to 12. Other porters may comment here. > > I would just keep it consistent. > > > > I cannot comment about $(INSTALLSITEARCH) patch, but I assume it's > > needed. > > > > > > Just to be clear, if you want to remove textproc/p5-LibXML-Common from > > the tree because this module was merged into textproc/p5-XML-LibXML you > > need *both* conflict and pkgpath markers in p5-XML-LibXML's PLIST. > > > > > > -- > > best regards > > q# > > > > > Index: p5-XML-LibXML/Makefile > =================================================================== > RCS file: /cvs/ports/textproc/p5-XML-LibXML/Makefile,v > retrieving revision 1.36 > diff -u -p -r1.36 Makefile > --- p5-XML-LibXML/Makefile 5 Jan 2011 18:18:25 -0000 1.36 > +++ p5-XML-LibXML/Makefile 20 Aug 2011 08:37:02 -0000 > @@ -4,14 +4,13 @@ SHARED_ONLY= Yes > > COMMENT= perl interface to the libxml2 library > > -DISTNAME= XML-LibXML-1.69 > +DISTNAME= XML-LibXML-1.84 > EPOCH= 0 > CATEGORIES= textproc > -USE_GROFF = Yes > > LIB_DEPENDS= textproc/libxml > -RUN_DEPENDS= textproc/p5-LibXML-Common \ > - textproc/p5-XML-SAX > +RUN_DEPENDS= textproc/p5-XML-NamespaceSupport>=1.07 \ > + textproc/p5-XML-SAX>=0.11 > BUILD_DEPENDS= ${RUN_DEPENDS} > > # GPL/Artistic > @@ -23,6 +22,6 @@ PERMIT_DISTFILES_FTP= Yes > MODULES= cpan \ > converters/libiconv > > -WANTLIB= m z xml2>=6 > +WANTLIB= m z xml2>=7 > > .include <bsd.port.mk> > Index: p5-XML-LibXML/distinfo > =================================================================== > RCS file: /cvs/ports/textproc/p5-XML-LibXML/distinfo,v > retrieving revision 1.11 > diff -u -p -r1.11 distinfo > --- p5-XML-LibXML/distinfo 8 Dec 2008 15:18:20 -0000 1.11 > +++ p5-XML-LibXML/distinfo 20 Aug 2011 08:37:02 -0000 > @@ -1,5 +1,5 @@ > -MD5 (XML-LibXML-1.69.tar.gz) = gpX0rnsJcpmF3REz460NCg== > -RMD160 (XML-LibXML-1.69.tar.gz) = G6nl1jQxrhEDH8oY4o2l8E/iXyM= > -SHA1 (XML-LibXML-1.69.tar.gz) = qFkK2mRj47HeVpn3uKFLVkQ3ohM= > -SHA256 (XML-LibXML-1.69.tar.gz) = > x9zDKgYXjFNCW3FShr6FMxuBm5thIRoDlrCOhek3H9E= > -SIZE (XML-LibXML-1.69.tar.gz) = 312095 > +MD5 (XML-LibXML-1.84.tar.gz) = 3mqS8dJVh1R9xucN7HQokw== > +RMD160 (XML-LibXML-1.84.tar.gz) = YC7bEa8/MZZWjUlBC3kxLC05DiM= > +SHA1 (XML-LibXML-1.84.tar.gz) = dtEReWfM6S34pT6C3cqFmsqA/i8= > +SHA256 (XML-LibXML-1.84.tar.gz) = > MOzUvnm2t/NNjhcYDeg8DBJmf9oHFIDmDFzjMWTZuwQ= > +SIZE (XML-LibXML-1.84.tar.gz) = 429541 > Index: p5-XML-LibXML/patches/patch-Makefile_PL > =================================================================== > RCS file: /cvs/ports/textproc/p5-XML-LibXML/patches/patch-Makefile_PL,v > retrieving revision 1.4 > diff -u -p -r1.4 patch-Makefile_PL > --- p5-XML-LibXML/patches/patch-Makefile_PL 7 Nov 2006 18:16:02 -0000 > 1.4 > +++ p5-XML-LibXML/patches/patch-Makefile_PL 20 Aug 2011 08:37:02 -0000 > @@ -1,13 +1,13 @@ > ---- Makefile.PL.orig Sun Sep 24 17:27:58 2006 > -+++ Makefile.PL Mon Nov 6 18:30:01 2006 > -@@ -314,8 +314,8 @@ sub MY::install { > +--- Makefile.PL.orig Wed Aug 17 21:27:36 2011 > ++++ Makefile.PL Wed Aug 17 21:28:05 2011 > +@@ -387,8 +387,8 @@ sub MY::install { > $script .= <<"INSTALL"; > > install_sax_driver : > --\t\@\$(PERL) -I\$(INSTALLSITELIB) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX::Parser))->save_parsers()" > --\t\@\$(PERL) -I\$(INSTALLSITELIB) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX))->save_parsers()" > -+#\t\@\$(PERL) -I\$(INSTALLSITELIB) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX::Parser))->save_parsers()" > -+#\t\@\$(PERL) -I\$(INSTALLSITELIB) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX))->save_parsers()" > +-\t\@\$(PERL) -I\$(INSTALLSITELIB) -I\$(INSTALLSITEARCH) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX::Parser))->save_parsers()" > +-\t\@\$(PERL) -I\$(INSTALLSITELIB) -I\$(INSTALLSITEARCH) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX))->save_parsers()" > ++#\t\@\$(PERL) -I\$(INSTALLSITELIB) -I\$(INSTALLSITEARCH) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX::Parser))->save_parsers()" > ++#\t\@\$(PERL) -I\$(INSTALLSITELIB) -I\$(INSTALLSITEARCH) -MXML::SAX -e > "XML::SAX->add_parser(q(XML::LibXML::SAX))->save_parsers()" > > INSTALL > } else { > Index: p5-XML-LibXML/pkg/PLIST > =================================================================== > RCS file: /cvs/ports/textproc/p5-XML-LibXML/pkg/PLIST,v > retrieving revision 1.17 > diff -u -p -r1.17 PLIST > --- p5-XML-LibXML/pkg/PLIST 8 Dec 2008 15:18:20 -0000 1.17 > +++ p5-XML-LibXML/pkg/PLIST 20 Aug 2011 08:37:02 -0000 > @@ -1,10 +1,17 @@ > -@comment $OpenBSD: PLIST,v 1.17 2008/12/08 15:18:20 simon Exp $ > +@comment $OpenBSD$ > +@pkgpath textproc/p5-LibXML-Common > +@conflict p5-XML-LibXML-Common-* > +${P5ARCH}/ > +${P5ARCH}/XML/ > +${P5ARCH}/XML/LibXML/ > ${P5ARCH}/XML/LibXML.pm > ${P5ARCH}/XML/LibXML.pod > ${P5ARCH}/XML/LibXML/Attr.pod > ${P5ARCH}/XML/LibXML/Boolean.pm > ${P5ARCH}/XML/LibXML/CDATASection.pod > ${P5ARCH}/XML/LibXML/Comment.pod > +${P5ARCH}/XML/LibXML/Common.pm > +${P5ARCH}/XML/LibXML/Common.pod > ${P5ARCH}/XML/LibXML/DOM.pod > ${P5ARCH}/XML/LibXML/Document.pod > ${P5ARCH}/XML/LibXML/DocumentFragment.pod > @@ -25,6 +32,7 @@ ${P5ARCH}/XML/LibXML/Parser.pod > ${P5ARCH}/XML/LibXML/Pattern.pod > ${P5ARCH}/XML/LibXML/Reader.pm > ${P5ARCH}/XML/LibXML/Reader.pod > +${P5ARCH}/XML/LibXML/RegExp.pod > ${P5ARCH}/XML/LibXML/RelaxNG.pod > ${P5ARCH}/XML/LibXML/SAX/ > ${P5ARCH}/XML/LibXML/SAX.pm > @@ -38,6 +46,9 @@ ${P5ARCH}/XML/LibXML/Text.pod > ${P5ARCH}/XML/LibXML/XPathContext.pm > ${P5ARCH}/XML/LibXML/XPathContext.pod > ${P5ARCH}/XML/LibXML/XPathExpression.pod > +${P5ARCH}/auto/ > +${P5ARCH}/auto/XML/ > +${P5ARCH}/auto/XML/LibXML/ > ${P5ARCH}/auto/XML/LibXML/LibXML.bs > ${P5ARCH}/auto/XML/LibXML/LibXML.so > @man man/man3p/XML::LibXML.3p > @@ -45,6 +56,7 @@ ${P5ARCH}/auto/XML/LibXML/LibXML.so > @man man/man3p/XML::LibXML::Boolean.3p > @man man/man3p/XML::LibXML::CDATASection.3p > @man man/man3p/XML::LibXML::Comment.3p > +@man man/man3p/XML::LibXML::Common.3p > @man man/man3p/XML::LibXML::DOM.3p > @man man/man3p/XML::LibXML::Document.3p > @man man/man3p/XML::LibXML::DocumentFragment.3p > @@ -62,6 +74,7 @@ ${P5ARCH}/auto/XML/LibXML/LibXML.so > @man man/man3p/XML::LibXML::Parser.3p > @man man/man3p/XML::LibXML::Pattern.3p > @man man/man3p/XML::LibXML::Reader.3p > +@man man/man3p/XML::LibXML::RegExp.3p > @man man/man3p/XML::LibXML::RelaxNG.3p > @man man/man3p/XML::LibXML::SAX.3p > @man man/man3p/XML::LibXML::SAX::Builder.3p -- best regards q#