[cc'ing ports@]

On Tue, Aug 30, 2011 at 05:24:54PM -0400, Brad wrote:
> >-pre-configure:
> >-    @cd ${WRKSRC}&&  \
> >+post-patch:
> >+    @cd ${WRKSRC}&&  env \
> >             AUTOCONF_VERSION=${AUTOCONF_VERSION} \
> >             AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
> >             ${MAKE_PROGRAM} -f Makefile.dist
> >
> 
> It would be nice if this stuff was standardized across the tree.
> There is a mix of the two targets being used throughout the tree
> for calling autogen.sh/Makefile.dist or whatever means of
> regenerating the autoconf/automake bits in a project.

AFAIK, the standard targets (if CONFIGURE_STYLE=autoconf or automake)
are all tied to post-patch. So your diff is good and people maintaining
ports with special autoconf/automake targets should work on similar
diffs. That is: run autoconf and/or automake during post-patch *if*
you have to run it explicitely.

Reply via email to