On 11/19/11 19:47, Dédé Gerard wrote:
> I'm really sorry, I sent you a bad archive without the patch.
> The new one is the good archive.
> Really sorry
>
>
>
> ________________________________
> De : Dédé Gerard <cypheri...@ymail.com>
> À : "ports@openbsd.org" <ports@openbsd.org>
> Envoyé le : Samedi 19 Novembre 2011 20h10
> Objet : PORT : srm
>
>
> I have ported srm to OpenBSD, and I would like you to add it to the cvs
> repository.
> Is joined to this mail an archive of the folder.
> I tested it in two amd64 computers with SATA and IDE hard disks on OpenBSD
> 5.0 -current, and it's working correctly.
>
> Sincerely,
> Maxime
Hi,
It helps to specify the category and a summary of a new port when
e-mailing to the ports mailist. rm(1) -P option already exists in
OpenBSD. So there needs to be a reason for importing srm, than a simple
replacement of existing functionality. The inclusion of the additional
overwriting methods for example.
The DESCR file shouldn't contain the HOME page. The name/mail address in
the DESCR isn't listed as an author of the software, who as far as I can
tell is one of the authors earlier editions of the book anti-hacker tool
kit.
>From the porter's guide use fmt -w72 for the description, not wrapped at
80 characters.
License is wrong initially it was GPL v1.1 then changed to X11/MIT for
srm code.
The getopt, snprintf are already available in the OpenBSD libraries the
code in lib shouldn't be built and linked, especially as this code is
GPL rather than X11/MIT, and confuses the license. A bug should be
raised upstream.
The patch change you made isn't suitable to send upstream.
Attached is a diff, with Makefile and DESCR updated, this builds
subdirectories doc and srm only, srm is built with OpenBSD libraries and
not those in lib, and license changed to X11/MIT.
Nigel
diff -rPNu srm.orig/Makefile srm/Makefile
--- srm.orig/Makefile Sat Nov 19 19:38:49 2011
+++ srm/Makefile Sun Nov 20 22:53:07 2011
@@ -10,9 +10,12 @@
MAINTAINER= Maxime Villard <cypheri...@ymail.com>
CONFIGURE_STYLE= gnu
+
+MAKE_FLAGS += SUBDIRS="src doc" INCLUDES="" srm_LDADD="" srm_DEPENDENCIES=""
+
NO_REGRESS= Yes
WANTLIB += c
-# GPL
+# X11/MIT
PERMIT_PACKAGE_CDROM= Yes
PERMIT_PACKAGE_FTP= Yes
PERMIT_DISTFILES_CDROM= Yes
diff -rPNu srm.orig/patches/patch-src_sunlink_c srm/patches/patch-src_sunlink_c
--- srm.orig/patches/patch-src_sunlink_c Sat Nov 19 19:38:49 2011
+++ srm/patches/patch-src_sunlink_c Sun Nov 20 23:41:56 2011
@@ -6,7 +6,7 @@
#if defined(__linux__)
srm.buffer_size = fs_stats.f_bsize;
-#elif defined(__FreeBSD__) || defined(__APPLE__)
-+#elif defined(__OpenBSD__) || defined(__APPLE__)
++#elif defined(__FreeBSD__) || defined(__APPLE__) || defined(__OpenBSD__)
srm.buffer_size = fs_stats.f_iosize;
#else
#error Please define your platform.
diff -rPNu srm.orig/pkg/DESCR srm/pkg/DESCR
--- srm.orig/pkg/DESCR Sat Nov 19 19:38:49 2011
+++ srm/pkg/DESCR Sun Nov 20 22:39:41 2011
@@ -1,10 +1,4 @@
-Secure rm (srm) is a command-line utility compatible with rm(1) which destroys
-file contents before unlinking. The goal is to provide drop-in security for
-users who wish to prevent command-line recovery of deleted information, even if
-the machine is compromised.
-
-WWW: http://sourceforge.net/projects/srm
-
-Keith J. Jones
-kjo...@antihackertoolkit.com
-
+Secure rm (srm) is a command-line utility compatible with rm(1) which
+destroys file contents before unlinking. The goal is to provide drop-in
+security for users who wish to prevent command-line recovery of deleted
+information, even if the machine is compromised.
