On 2012/01/22 23:36, Andrew Fresh wrote:
> I had a little time to make this work, but not a lot of time to make
> sure it didn't cause any problems.  

Reads OK with minor nits;

> Index: devel/p5-Class-Unload/Makefile
> +COMMENT=     Unload a class
> +USE_GROFF=   Yes

> Index: databases/p5-DBIx-Class-IntrospectableM2M/Makefile
> +COMMENT=     Introspect many-to-many shortcuts

> Index: devel/p5-Data-Dumper-Concise/Makefile
> +COMMENT=             Less indentation and newlines plus sub deparsing

> Index: textproc/p5-Lingua-EN-Inflect-Phrase/Makefile
> +COMMENT=     Inflect short English Phrases

> Index: textproc/p5-Lingua-EN-Tagger/Makefile
> +COMMENT=     Part-of-speech tagger for EN natural language processing

> Index: devel/p5-Memoize-ExpireLRU/Makefile
> +COMMENT=     Expiry plug-in for Memoize that adds LRU cache expiration

> Index: textproc/p5-String-ToIdentifier-EN/Makefile
> +COMMENT=     Convert Strings to English Program Identifiers

Lowercase start of COMMENT please, and does Class::Unload actually need
groff? (perldoc-produced manuals often don't).

Let me know how the regress tests get on. If it sticks at this set
of ports needing updating/adding I think we are probably OK with doing
it now, but if we end up having to update huge chunks of Catalyst as
well, we're going to need to defer until after we're done with 5.1.

Comment about audio/squeezecenter which depends on DBIx::Class; it may
possibly have problems with this, but it's practically unmaintanable
anyway so I have to say I wouldn't worry too much about that if it's
getting in your way.

(if anyone is interested in picking up the squeezecenter port, I suggest
moving to the internal copies of modules as much as possible, yeah it
sucks, but so does keeping track of dirty dependencies on internal APIs
of a subtantial proportion of the ~50 modules it needs - personally
I have since switched my squeezeboxes to connecting to vortexbox
running as a VM instead, mounting music by NFS, not exactly my first
choice but it works really well ..)

Reply via email to