On 2012/03/23 10:07, Gonzalo L. R. wrote:
> +++ pkg/MESSAGE       23 Mar 2012 13:01:17 -0000
> @@ -1,12 +1,6 @@
> -To have ipguard start at boot time, add the following line
> -to /etc/rc.conf.local, substituting the flags as needed:
> +You have a rc.d(8) file to start ipguard at boot time, as
> +example the file /etc/rc.d/ipguard have set the device

typically we don't talk about rc.d files in MESSAGE; though this
may warrant a *short* entry like this:

To use ipguard with rc.d(8), set a network interface in rc.conf.local, e.g.:
ipguard_flags="em0"

> +em(4), you need to change this for your own device in
> +the line:

rc.d scripts are not intended to be user-editable, you should set
<daemonname>_flags in rc.conf.local instead, see ENVIRONMENT in
rc.d(8).

> --- pkg/PLIST 11 May 2011 08:24:40 -0000      1.5
> +++ pkg/PLIST 23 Mar 2012 13:01:17 -0000
> @@ -6,3 +6,4 @@
>  @extraunexec rm -rf /var/log/ipguard/*
>  @group _ipguard
>  @sample /var/log/ipguard/
> +@rcscript ${RCDIR}/ipguard

Group ownership for the script is incorrect, add a line "@group"
after the @sample.

> # $OpenBSD$
> 
> daemon="${TRUEPREFIX}/sbin/ipguard"
> daemon_flags="em0"
> 
> . /etc/rc.d/rc.subr
> 
> rc_pre() {

The BUGS section in ipguard's manpage says "Signals HUP, USR1 or USR2
works only when received new ARP packet" so reload doesn't work how
people expect; therefore I think this should have

rc_reload=NO

before the rc_pre() line.

Reply via email to