On 2012/09/11 13:21, Sascha Retzki wrote: > Hello List, > > I ran into a segmentation fault of tacacs+, but just on amd64 when there > was no reverse lookup (no -L or dns flaky). Package version is > tacacs+-4.0.4ap1 and this is OpenBSD 5.1. > Port maintainer forgot to patch the header-files for inet_ntoa() > into tac_plus.c, resulting in the return type to become int, which > happens to work in 32bit systems, but not on 64bit. > > So, patch-tac_plus_c needs to become: > +#include <sys/types.h> > +#include <sys/socket.h> > +#include <netinet/in.h> > +#include <arpa/inet.h> > +#include <grp.h>
thanks, I've committed a fix for this. > (I'd make a patch for the patch, or create a new patch, if I knew the exact > things I have to jam into diff(1), so well, sorry if this is too manual) For reference, it roughly goes like this: make patch cd `make show=WRKSRC` cp $FOO $FOO.orig vi $FOO cd - make update-patches Then 'cvs add' the new patches and 'cvs diff -uNp'.
