On Mon, Oct 1, 2012 at 5:28 PM, Federico Schwindt <fg...@lodoss.net> wrote:
> On Mon, Oct 1, 2012 at 4:02 PM, David Coppa <dco...@gmail.com> wrote:
>> On Mon, Oct 1, 2012 at 4:59 PM, Stuart Henderson <s...@spacehopper.org>
>> wrote:
>>> On 2012/10/01 15:08, Federico Schwindt wrote:
>>>> > The diff below should do the trick (not tested, qt4 is such a beast to
>>>> > build)...
>>>> >
>>>> > Grepping for "QLibrary ", finds other occurrences that maybe we should
>>>> > also fix.
>>>>
>>>> I'm not sure about this. It seems to me that this:
>>>>
>>>> >> dlopen: loading: libicui18n
>>>>
>>>> Should really be libicui18n.so. I think this is better but untested
>>>> and straight from the source:
>>>
>>>> --- qlibrary_unix.cpp.orig Mon Oct 1 14:59:57 2012
>>>> +++ qlibrary_unix.cpp Mon Oct 1 15:00:28 2012
>>>> @@ -143,9 +143,8 @@
>>>> #endif // Q_OS_AIX
>>>> if (!fullVersion.isEmpty()) {
>>>> suffixes << QString::fromLatin1(".so.%1").arg(fullVersion);
>>>> - } else {
>>>> - suffixes << QLatin1String(".so");
>>>> }
>>>> + suffixes << QLatin1String(".so");
>>>> #endif
>>>> # ifdef Q_OS_MAC
>>>> if (!fullVersion.isEmpty()) {
>>>>
>>>> f.-
>>>
>>> I haven't tested yet, but this seems a much better approach than
>>> patching the callers.
>>
>> Sure, I also think Federico got it right.
>
> Ok, attached. Ttested with keepassx and a demo for the cups patch removal.
> The gtk patch removal still needs testing. Anyone?
>
> f.-
I tested it and then removed the diff from my ports tree... I need
this patch to go in because kdelibs 4.9.2 is complaining about the
same thing i.e Cannot load library icui18n
will somebody commit this after approval? marc?
