On Thu, Oct 25, 2012 at 12:01:47PM -0400, Brian Callahan wrote:
> Hi ports --
> 
> I got devel/spidermonkey working on one of my loongson machines.
> Builds/installs OK and 'make regress' passes all tests. That's as
> far as I've gotten testing-wise.

wow, that is awesome ! Now, i dont agree with some parts of the patch
that mix stuff for mips*/mips64 with things that might be mips64el only
- maybe a little variation of this would allow spidermonkey to build on
'regular' mips64.

Can you try building www/fennec then firefox with that patch applied to
js/src ?

Landry

> ++# XXX: Fix for mips64el
> ++ifeq (mips, $(CPU_ARCH))
> ++CXXFLAGS += -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=0 -DENABLE_JIT=0
> ++else
> + CXXFLAGS += -DUSE_SYSTEM_MALLOC=1 -DENABLE_ASSEMBLER=1 -DENABLE_JIT=1
> ++endif

Oh, the horror. I've been there, and it's an atrocious define hell.
that wont be acceptable upstream, see
https://bugzilla.mozilla.org/show_bug.cgi?id=691898 for the hell it's
been with ppc.

> + ++/* CPU(MIPS64) - MIPS64 (Loongson only!) */
> ++#if defined(__mips64__)

mips64el here ?

> + +-mips|mipsel)
> ++mips*)
> +     CPU_ARCH="mips"

I'd rather have a new section adding mips64|mips64el..
or add them to the same section? that part should be taken upstream.
See the section setting ENABLE_METHODJIT in configure.in, i've been
told to add     if test ! "$HAVE_64BIT_OS" ; then to set those bits only
on sparcv8 and not sparcv9 - same thing might be needed for mips64.

> +@@ -2515,7 +2515,7 @@ ia64*-hpux*)
> +     alpha-*)
> +             AC_DEFINE(_ALPHA_)
> +     ;;
> +-    mips-*)
> ++    mips*-*)
> +             AC_DEFINE(_MIPS_)

Ditto here, that should be upstreamable. Can you file a bug on
bugzilla.mozilla.org with all your findings and cc me on it ?

Landry

Reply via email to