On Thu, Nov 01, 2012 at 02:37:26PM +0100, Landry Breuil wrote:
> On Thu, Nov 01, 2012 at 08:57:26AM -0400, Stuart Cassoff wrote:
> > On 10/10/12 03:01, Stuart Cassoff wrote:
> > > Latest. Tested on i386 w/camera, lightly tested on amd64.
> > >
> >
> > Ok?
>
> - missing dep/goos for x11/gtk+2,-guic for the hicolor icon cache
> - WTF is that gross LD_PRELOAD for pangocairo.so in the launcher ?
> - please keep the Makefile diff simpler to read by not doing the tab
> changes at the same time, those can come later. Current makefile diff
> is unreadable.
> - split the DEPENDS lines on multiple lines with \ like every other port
> do
> - document patches for non-straightforward changes..
- missing run dep on shared-mime-info to get the update-mime-database
dep (+ share/mime dirs should go away upon update-plist)
- the .po files are in a strange location.. do translations work ? you
should check against gettext, because usually they're in
share/locale/${lang}/LC_MESSAGES...
Landry
