On Mon, Nov 5, 2012 at 8:49 PM, David Coppa <dco...@gmail.com> wrote:
> On Mon, Nov 5, 2012 at 8:00 PM, Vadim Zhukov <persg...@gmail.com> wrote:
>> On 5 ноября 2012 г. 10:21:06 David Coppa wrote:
>>> On Mon, Nov 5, 2012 at 7:05 AM, David Coppa <dco...@gmail.com> wrote:
>>> >> what changed in the meantime? some tightening?
>>> >
>>> > Yeah, very strange. This always used to work without patching.
>>> > Further investigation is needed :(
>>>
>>> Ok, I've found it.
>>>
>>> I think it's a regression from 2.8.9...
>>>
>>> Change line 62 of /usr/local/share/cmake/Modules/FindFreetype.cmake
>>> from:
>>>
>>> PATH_SUFFIXES include/freetype2 include
>>>
>>> To:
>>>
>>> PATH_SUFFIXES freetype2 include/freetype2 include
>>>
>>>
>>> I will provide a new patch after. I'm now trying to find the problems
>>> with gettext Landry has pointed out.
>>
>> Looks like someone upstream did it 180 degrees right. PATH_SUFFIXES
>> doesn't need to mention "include" at all. This patches works fine too
>> and probably should be pushed upstream (to be appended to initial
>> David's patch).
>
> Thanks Vadim, I'll use your patch.
>
> It seems to me that this release is lower on quality than previous releases.
> FindGettext.cmake is also broken and I had to revert a commit to make
> it work as expected.
> I'll send the new diff as soon as possible...

Here's the new diff (attached).
This should hopefully survive through a bulk build.

Cheers,
David

Attachment: cmake-2.8.10_v2.diff.gz
Description: GNU Zip compressed data

Reply via email to