On Tue, Dec 11, 2012 at 08:58:05PM +0000, Stuart Henderson wrote:
> On 2012/12/11 19:54, Giovanni Bechis wrote:
> > On 12/11/12 19:49, David Coppa wrote:
> > > On Tue, Dec 11, 2012 at 7:39 PM, Giovanni Bechis <giova...@bigio.snb.it> 
> > > wrote:
> > >> Update to latest version, a lua.port.mk diff is needed to build it 
> > >> because it needs at least lua 5.2.
> > >> Comments ? Hints ? Ok ?
> > >>  Cheers
> > >>   Giovanni
> > > 
> > > imho this is not right.
> > > Just set MODLUA_VERSION=5.2 into net/nmap/Makefile
> > > 
> > This does not work, lua.port.mk still thinks that lua-5.1 is needed.
> 
> That should be fixed so it works then, overriding MODLUA_DEFAULT_VERSION
> like this is definitely wrong.
> 
> OK?
Thanks; certainly OK.
 
> Index: lua.port.mk
> ===================================================================
> RCS file: /cvs/ports/lang/lua/lua.port.mk,v
> retrieving revision 1.23
> diff -u -p -r1.23 lua.port.mk
> --- lua.port.mk       31 Oct 2012 13:39:32 -0000      1.23
> +++ lua.port.mk       11 Dec 2012 20:57:17 -0000
> @@ -24,7 +24,7 @@ FLAVOR?=            # empty
>  .if ${FLAVOR:L:Mlua52}
>  MODLUA_VERSION=              5.2
>  .else
> -MODLUA_VERSION=              ${MODLUA_DEFAULT_VERSION}
> +MODLUA_VERSION?=     ${MODLUA_DEFAULT_VERSION}
>  .endif
>  
>  .if "${MODLUA_VERSION}" == "5.1"
> 

-- 
Cheers,
Jasper

"Stay Hungry. Stay Foolish"

Reply via email to