On Fri, Jan 25, 2013 at 01:46:08AM -0500, Brad Smith wrote: > On Fri, Jan 25, 2013 at 07:43:09AM +0100, Antoine Jacoutot wrote: > > On Thu, Jan 24, 2013 at 11:48:08PM -0500, Brad Smith wrote: > > > On Wed, Jan 23, 2013 at 09:59:32PM -0500, Brian Callahan wrote: > > > > Hi ports -- > > > > > > > > Attached is a rather large diff that removes --disable-external-libs > > > > from audio/libsndfile, pulls ogg, vorbis and flac into libsndfile > > > > (the external libs), and bumps all dependent ports that need it. > > > > > > > > This change is needed to import audio/mscore. Mscore can save files > > > > as flac and ogg, but only via libsndfile. > > > > > > > > This diff is identical to the latest one I sent to all MAINTAINERS > > > > of the affected ports, with the addition of adding Jan Stary as > > > > MAINTAINER of libsndfile and libsamplerate. > > > > > > > > I have an ok from landry@ and aja@. Also a "no problems with > > > > audio/aqualung with this, I didn't test other programs" from jeremy@ > > > > and a "no objections" from Jan Stary. Anyone else want to weigh in > > > > on this before I commit it? > > > > > > > > ~Brian > > > > > > Don't remove the LIB_DEPENDS. > > > > Why? > > I hate hiding dependencies in the name of "simplifying" dependencies. > I want to see which ports have dependencies on which libraries and > increasingly these are being hidden.
If you go this way, then you are missing at least graphics/cairo, x11/dbus, /audio/libogg, ... For the ports I maintain, Brian you can keep removing the LIB_DEPENDS since this is how we do stuffs. -- Antoine
