On 2013/03/31 10:02, Roman Kravchuk wrote:
> Hello ports,
>
> This is a port of kannel, compact and very powerful open source WAP
> and SMS gateway
>
> Tested on current amd64.
>
> Ok? Comments?
>
> Thanks.
>
> - Roman
- first thing to say is "ouch" that you had to patch MACHINE in so
many files to avoid a conflict with param.h!
- flavour handling is incorrect - pseudo flavours are *only* valid
with subpackages, to disable some subpackage/s from being built.
the options here all affect the main package, so they must be
FLAVORS, and in that case the no_XXX naming is awkward (for example
the package of the "no database" version would be name
kannel-$VER-no_mysql-no_pgsql-no_sqlite) so it would be better
to call them "pgsql" and "mysql".
- there isn't much point in having an option to disable sqlite3,
since it is in base OpenBSD. I don't think there is much point in
having no_pcre either, it's a fairly small and common dependency.
by having fewer build options, it's easier to test that the port
works correctly, and takes less time in bulk builds.
- please add the svn url in a comment near MASTER_SITES
- the shell scripts (files/*) hardcode /usr/local, the easiest way to
fix this is probably to use ${SUBST_CMD} -c to copy them into WRKDIR or
WRKSRC, and then ${INSTALL_SCRIPT} from there
- bad permission on the rc script; reset @mode/@owner/@group before
the @rcscript line in plist.
- "Kannel Software License" isn't well known, I think it would be
better to write something like this:
# BSD-like with naming restrictions, see http://kannel.org/license.shtml
