2013/5/8 Stuart Henderson <st...@openbsd.org>:
> On 2013/05/08 09:22, Илья Шипицин wrote:
>> up
>>
>> 2013/5/4 Илья Шипицин <chipits...@gmail.com>:
>> > hmm, next patch edition.
>> >
>> > --- devel/pcre/Makefile.orig Sat May 4 14:57:28 2013
>> > +++ devel/pcre/Makefile Sat May 4 12:17:52 2013
>> > @@ -30,11 +30,18 @@
>> > USE_LIBTOOL= Yes
>
> Ports submissions should be sent as a cvs diff against -current,
> -current does not gave this line.
pardon, I made patch againt 5.3
>
> Missing a bump to REVISION.
what do you mean ?
>
>> > USE_GROFF = Yes
>> > CONFIGURE_STYLE= gnu
>> > +
>> > CONFIGURE_ARGS= ${CONFIGURE_SHARED} \
>> > --enable-pcre8 \
>> > --enable-pcre16 \
>> > --enable-utf \
>> > - --enable-unicode-properties
>> > + --enable-unicode-properties
>> > +
>> > +.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386" ||
>> > ${MACHINE_ARCH} == "powerpc" || ${MACHINE_ARCH} == "powerpc64" ||
>
> we don't have a powerpc64 arch.
I made grep against "Makefile" in ports, so the following is bug, fix it please:
# find /usr/ports/ -name Makefile -exec grep powerpc64 {} ';' -print
.elif ${MACHINE_ARCH} == "powerpc64"
/usr/ports/security/john/Makefile
>
> from a quick look at files, I'm not convinced they support sparc64,
> maybe only sparc.
maybe
>
>> > ${MACHINE_ARCH} == "mips64" || ${MACHINE_ARCH} == "mips64el" ||
>> > ${MACHINE_ARCH} == "arm"
>
> pcre is used by a number of important ports, for example glib2,
> apache-httpd, postfix, kamailio, exim, cyrus-imapd, kde-libs.
> What tests have you done, and on what arches?
pcre does include unit tests, which can be easily run by "make test",
for example, tests 14 and 15 are about JIT.
should we modify port in order to run those tests after build ?
automatic tests are good.
as for myself, I'm running nginx, I find pcre_jit very impressive. and stable.
I can only test on amd64.
>
>> > +CFLAGS+=-lpthread
>
> This would probably change WANTLIB.
probably
>
>> > +CONFIGURE_ARGS+=--enable-jit
>
> What are the security imolications?
what ?
