Comments?

http://marc.info/?l=openbsd-ports&m=136871182828326&w=2

Regards,
 Mikolaj

On Thu, May 16, 2013 at 02:34:47PM +0100, Mikolaj Kucharski wrote:
> Hi,
> 
> Here is beginning of a build log of random port:
> 
> 
> ===>  Looking for unrar-4.20v1.tgz in $PKG_PATH - not found
> *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1824
> '/usr/ports/packages/i386/cache//unrar-4.20v1.tgz': @if /usr/bin/env -i
> PKG_...)
> ===>  Checking files for unrar-4.20v1
> `/usr/ports/distfiles/unrarsrc-4.2.4.tar.gz' is up to date.
> >> (SHA256) unrarsrc-4.2.4.tar.gz: OK
> ===>  Verifying specs: c crypto m stdc++ c crypto m stdc++
> ===>  found c.68.0 crypto.22.0 m.8.0 stdc++.55.0
> ===>  Extracting for unrar-4.20v1
> ===>  Patching for unrar-4.20v1
> ===>  Configuring for unrar-4.20v1
> ===>  Building for unrar-4.20v1
> ...
> 
> 
> I often find above '*** Error 1 in ...' unnecessary noise when package
> was not found. Below patch mutes those errors. It makes greping for
> errors mutch easier.
> 
> Comments?
> 
> 
> Index: bsd.port.mk
> ===================================================================
> RCS file: /cvs/ports/infrastructure/mk/bsd.port.mk,v
> retrieving revision 1.1224
> diff -u -p -r1.1224 bsd.port.mk
> --- bsd.port.mk       14 May 2013 13:38:59 -0000      1.1224
> +++ bsd.port.mk       16 May 2013 11:12:42 -0000
> @@ -1836,7 +1836,7 @@ ${_PACKAGE_COOKIE${_S}}:
>       @mkdir -p ${@D} ${_TMP_REPO}
>  .  if ${FETCH_PACKAGES:L} == "yes" && 
> !defined(_TRIED_FETCHING_${_PACKAGE_COOKIE${_S}})
>       @f=${_CACHE_REPO}/${_PKGFILE${_S}}; \
> -     cd ${.CURDIR} && ${MAKE} $$f && \
> +     cd ${.CURDIR} && ${MAKE} $$f 2>/dev/null && \
>               { ln $$f $@ 2>/dev/null || cp -p $$f $@ ; } || \
>               cd ${.CURDIR} && ${MAKE} 
> _TRIED_FETCHING_${_PACKAGE_COOKIE${_S}}=Yes _internal-package-only
>  .  else
> 
> 

-- 
best regards
q#

Reply via email to