On Tue, Oct 01, 2013 at 12:43:17PM -0700, Jeremy Evans wrote:
> On Sat, Sep 28, 2013 at 2:47 PM, Jiri B <ji...@devio.us> wrote:
> 
> > Hi,
> >
> > in order to update ruby-jekyll there's need to update
> > ruby-redcarpet and ruby-liquid.
> >
> > I'm *only* occassional user of jekyll, thus no real testing
> > of redcarpet and liquid. But jekyll works :-)
> >
> > I have to patch jekyll metadata file as gem was screaming
> > that redcarpet 3.0.0 is not higher than 2.3.0.
> >
> >
> This change is not kosher.  The gem spec is for ~>2.3.0, meaning
> >=2.3.0,<2.4.0.  You shouldn't be jumping redcarpet to 3.0.0 and then
> overriding the gem requirements in jekyll unless you have a very good
> reason to.  Why not just use redcarpet 2.3.0?
> 
> 
> > FYI While searching how to do it, I found that NetBSD pkgsrc
> > uses probably more elegant way. Example:
> >
> > OVERRIDE_GEMSPEC= directory-watcher>=1.5.1 safe_yaml>=0.9.5
> > redcarpet>=3.0.0
> >
> 
> Making it easier to do bad things does not strike me as a good idea.
> Hacking gem requirements should only be done if necessary, and this doesn't
> appear to be one of those cases.

+1

Either the gem requirements are real, and we shouldn't hack them.

Or somebody bumped them "just in case", and then it's a bug report
to upstream and a local patch until it's fixed.

Reply via email to