Hi Edd, Edd Barrett wrote on Tue, Oct 15, 2013 at 11:33:36PM +0100:
> An inkscape update: > > * Bugfix release. > * Loads of patches integrated upstream (bye bye glib/poppler hacks). > * Uses newer autoconf. > > A few bits I am unsure of: > > * 'make update-plist' wants to remove the icon dir entries. Really? Yes. inkscape run-depends on hicolor-icon-theme which already provides the directory share/icons/hicolor/. > * Does not appear to need groff anymore (?) Ugh, that question *could* be asked in a way that is a bit more specific. ;-) See http://www.openbsd.org/faq/ports/specialtopics.html#Mandoc "How do I report the results?" So i applied your patch, installed various dependencies, got the distribution tarball, searched the working dir below /usr/ports for manual pages, and redid the complete analysis of these pages. I found two: inkscape.1 and inkview.1. inkview.1 is just fine. inkscape.1 has 38 instances of "skipping bad character", all in author names, which i'd say you can safely ignore. Consequently, USE_GROFF is not needed. > * Not sure how much value the new translated manuals add, None. I'd say, just install none of them. > for example the > japanese manual does not appear to render properly with or without > groff. Shall we remove it? Yes, all of them, even the german and french ones. Basically, we don't have any support for indigenous languages manuals. Viewing them properly would require building with something like preconv inkscape.1 | mandoc -Tutf8 > inkscape.0 preconv inkscape.1 | nroff -c -mandoc > inkscape.0 which we just don't do, we haven't even imported preconv into the base system yet even though it is available in the mdocml.bsd.lv (portable) version of mandoc; we merely do mandoc inkscape.1 > inkscape.0 nroff -c -mandoc inkscape.1 > inkscape.0 With groff, the latter simply skips all UTF-8 characters in the input stream, with mandoc, it replaces them with "??". Even if we would get the encoding correct, viewing them requires UTF-8 support (which is not enabled by default) *and* reconfiguring /etc/man.conf to find them (which i doubt anybody is doing at all). Including them in the package is just a waste of space. Besides, translated manuals are usually of abysmal quality, so it actually *helps* users to not provide them and focus on providing the real, original manuals only. Yours, Ingo
