On 2014/06/09 19:59, Stuart Henderson wrote: > On 2014/06/09 16:15, Florian Stinglmayr wrote: > > Hi list, > > > > thanks to the work and comments from bcallah@ here is a fixed up port. > > It now depends on python as well, allowing it to run perl and python > > scripts. > > > > Florian > > This PLIST is missing some directories; it creates files in > directories which are neither listed in the PLIST nor come from a > dependent port, e.g. share/appdata, share/locale/ja_JP, lib/hexchat / > lib/hexchat/plugins. > > It would be better to avoid building the static-library version of > the plugins by using LIBTOOL_FLAGS = --tag=disable-static (then the > @comment'ed .a lines can go), and there's a hidden dependency on > at least libpci (sysinfo is built if it's present at configure > time, so this will fail sporadically in bulk builds), but check for > others - there are things like iso-codes in there too which may get > picked up. > > There's also a missing library (LIB_DEPENDS and WANTLIB) on python, > use the appropriate variables shown in the lang/python section of > port-modules(5) to set these rather than hardcoding these. >
Couple of othres: - "either version 2 of the License, or (at your option) any later version." -> use GPLv2+ in the license marker - text alignment is a bit messy, tabs should be 8 columns and try to make things line up a bit better - something's wrong with the --enable-socks, it doesn't pick up an installed libsocks? if it's not doing anything useful should it just be disabled? - empty PFRAG.shared; but because you use loadable modules it should be SHARED_ONLY so there shouldn't be a PFRAG.shared
