On 08/06/14 5:07 PM, Stuart Henderson wrote:
I was just looking at nghttp2 which uses pkg-config to check for openssl
version 1.0.1 or higher and noticed that we're still setting it to 1.0.0
(#define SHLIB_VERSION_NUMBER "1.0.0" in src/crypto/opensslv.h).
I think we should at least bump this to 1.0.1 (though probably wants a
bulk build), however, I see on a Linux machine that they use the full
alphanumeric version:
sl6$ pkg-config --modversion openssl
1.0.1e
sl6$ pkg-config --atleast-version 1.0.1e openssl && echo yes
yes
sl6$ pkg-config --atleast-version 1.0.1g openssl && echo yes
sl6$ pkg-config --atleast-version 1.0.1 openssl && echo yes
yes
So I tried using that in opensslv.h here - I haven't run across
anything doing that sort of check yet, but it's probably just a matter
of time, so maybe we should support it in our pkg-config too..
current behaviour has warnings and partly works, but not reliably:
obsd$ pkg-config --modversion openssl
1.0.1g
obsd$ pkg-config --atleast-version 1.0.1e openssl && echo yes
Argument "1e" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
Argument "1g" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
yes
obsd$ pkg-config --atleast-version 1.0.1 openssl && echo yes
Argument "1g" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
yes
obsd$ pkg-config --atleast-version 1.0.1h openssl && echo yes
Argument "1h" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
Argument "1g" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
yes
$ pkg-config --atleast-version 1.0.2 openssl && echo yes
Argument "1g" isn't numeric in numeric gt (>) at /usr/bin/pkg-config line 708.
So.. any thoughts about what to do? anyone fancy looking at pkg-config for
the proper fix for compatibility with original pkg-config? should we just
go for SHLIB_VERSION_NUMBER="1.0.1" for now?
The pkg-config file generation scripts for libssl / libcrypto should be
modified to parse OPENSSL_VERSION_TEXT for the proper version of
OpenSSL as the original code that generates these files does instead of
using SHLIB_VERSION_NUMBER which isn't the OpenSSL version.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
