On Thu, Jul 24, 2014 at 02:38:34AM +0400, Vadim Zhukov wrote: > 2014-07-24 0:18 GMT+04:00 Vadim Zhukov <persg...@gmail.com>: > > Hello all. > > > > This adds a useful but awfully slow feature: checking for unmarked > > conflicts. This is done as a part of PLIST checks, so it could be > > disabled by -P as well as by specifically added -C option. Yes, > > there was -C option at some time previously with different meaning, > > but I'm doubt we care about those times. :) > > > > The basic idea is that we accumulate up to $max_conflicts_queue_size, > > 1000 by now, file items and then run pkg_locate in a batch. We parse > > pkg_locate output, filter out implicit and explicit conflicts, and > > finally display warnings about each conflicting file. > > > > Actual speed is about 5 PLIST items per second on my X201i. Yes, > > it makes checking stuff like kdelibs and opencv-docs hell long. > > Unfortunately, locate(1) (and thus pkg_locate) re-scans database > > for each item on command line. This could be improved (I've already > > looked at the code) but definitely not while we're in release lock. > > > > So... any opinions? Okay to let this go in? > > > > BTW, this diff contains a bugfix required for the mentioned feature > > to work: I've used non-subpackaged version of FULLPKGNAME variable. > > I plan to commit this fix and other nit I found separately. > > Updated version (should apply clean to -CURRENT). Includes updates > to tests. > > -- > WBR, > Vadim Zhukov
Nope, this exists elsewhere. Reuse bin/check-conflicts
