2014-08-19 19:06 GMT+04:00 Antoine Jacoutot <ajacou...@bsdfrog.org>: > On Tue, Aug 19, 2014 at 06:58:53PM +0400, Vadim Zhukov wrote: >> 2014-08-19 3:24 GMT+04:00 Brian Callahan <bcal...@devio.us>: >> > Hi ports -- >> > >> > Attached is a new port, vimb. Vimb is another one of those vi-inspired web >> > browsers. >> > >> > pkg/DESCR: >> > Vimb is a fast and lightweight vim like web browser based on the webkit >> > web browser engine and the GTK toolkit. Vimb is modal like the great vim >> > editor and also easily configurable during runtime. Vimb is mostly >> > keyboard driven and does not detract you from your daily work. >> > >> > Works well on amd64, i386 (and other) testers appreciated. >> > >> > OK? >> >> You should probably use "LIB_DEPENDS = www/webkit," instead (notice >> the trailing comma), to make sure the GTK2 version of vimb doesn't >> depend on GTK3 version of Webkit. > > Not sure that will do it, will it?
No, it won't. Because two commas are actually needed. :) I.e.: LIB_DEPENDS = www/webkit,, Two commas will result in a dependency on a "www/webkit port, empty FLAVOR" instead of "www/webkit port, any FLAVOR". > Shouldn't sth like this be used? > webkit-*-!gtk3:www/webkit The package is named webkit-gtk3-VERSION, not webkit-VERSION-gtk3. So your pattern won't match. And that's the reason the FLAVOR tweaking is not needed, actually. :) When you depend on "www/webkit", the pkgspec will be resolved from the default FLAVOR. Effectively, the different dependency pkgspecs will be written in the resulting vimb package. So it looks like there is no problem here. > But if the WANTLIB are correct and refence the ones from the non gtk3 webkit, > I think nothing should be needed no? If I'm not mistaken, no. In case of WANTLIB mismatch you'll get an error when running pkg_add (because the package for dependency was already choosen and being tried), and in case of correct pkgspec you'll get a correct package choosen for dependency resolution. -- WBR, Vadim Zhukov