On Thu, October 2, 2014 12:40, Landry Breuil wrote: > On Thu, Oct 02, 2014 at 11:54:33AM +0400, Kirill Bychkov wrote: >> We're living in an age of clouds, so I want to introduce port of a client >> for >> "Next-generation Open Source Cloud Storage". >> http://seafile.com/en/home/ >> >> Currently only client is ported because server side is... well... not easy >> in >> configuration and it's port is incomplete. >> >> Tested against Linux server and library with very big and tons of small >> files. >> >> Comments? OK? >> >> P.S. You can find all the stuff in openbsd-wip. > > That mostly looks good to me, minor nits:
Hi! > - can you add comments to 'no-so-obvious-patches' ? like the removal of > evutil.h inclusion.. I've pushed upstream most of that patches, but not all of them were merged yet. I'll add comments where needed. > - add a comment explaining why a test is disabled in libzdb.. OK. It's just interactive and requires mysql/postgresql database. While here... I should switch to mariadb. > - seafile-admin references/hardcodes /var/seafile, while i dont see that > dir registered anywhere in a PLIST, nor with a corresponding user - is > that stuff supposed to be running as root ? This is a leftover from times when I was trying to make a port of seafile-server. By default seafile-admin script is performing actions in CWD, so one should cd to /var/seafile and run script there. It's ugly, so it was patched this way. I think I can even drop this script while there is no server subpackage. > - i see a desktop client and a daemon - do i understand that 'both' are > needed for client functionality ? How does the daemon start ? > Daemon is called by both server and client. It is performing some background voodoo-magic. It's not intended to be started manually. > Landry > >
