On 2014/10/30 22:08, Edd Barrett wrote: > Hey, > > Update to offlineimap. I have been running this for a while now. No > issues. First time I have used GH_*, so please check carefully. > > OK? > > Index: Makefile > =================================================================== > RCS file: /home/edd/cvsync/ports/mail/offlineimap/Makefile,v > retrieving revision 1.26 > diff -u -p -r1.26 Makefile > --- Makefile 11 Mar 2013 11:23:52 -0000 1.26 > +++ Makefile 30 Oct 2014 21:58:30 -0000 > @@ -2,7 +2,7 @@ > > COMMENT= powerful IMAP/Maildir synchronization and reader support > > -MODPY_EGG_VERSION= 6.5.4 > +MODPY_EGG_VERSION= 6.5.6 > DISTNAME= offlineimap-${MODPY_EGG_VERSION} > CATEGORIES= mail > > @@ -13,15 +13,17 @@ MAINTAINER= Pierre-Emmanuel Andre <pea@o > # GPLv2+ > PERMIT_PACKAGE_CDROM= Yes > > -MASTER_SITES= > https://github.com/spaetz/offlineimap/tarball/v${MODPY_EGG_VERSION}/ > +GH_ACCOUNT = OfflineIMAP > +GH_PROJECT = offlineimap > +GH_TAGNAME = v${MODPY_EGG_VERSION} > +GH_COMMIT = 7770b5ff73737d1269eb1ba7554b8d3486c7f5ec
I would put at least GH_COMMIT right up next to MODPY_EGG_VERSION to avoid risk of it being forgotten at update time. (Actually I would probably put the whole block up there. Seems a better place to me.) Rest looks good but I don't run offlineimap myself.