On 03/11/14 2:18 PM, Jonathan Armani wrote:
Hi,

Back on old diffs, remove esound from gtetrinet. This diff does not
prevent esound to be picked by configure but I plan to remove it
completly.

Is that acceptable ? Better idea ?

I noticed your diff adds libaudfile but there are no WANTLIB additions
which should be the case. I don't see anything in the gtetrinet code
that uses libaudfile. Was this intended? The rest of the diff looks
fine.

Index: Makefile
===================================================================
RCS file: /cvs/ports/games/gtetrinet/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- Makefile    11 Oct 2013 23:49:37 -0000      1.28
+++ Makefile    3 Nov 2014 19:13:48 -0000
@@ -6,7 +6,7 @@ COMMENT-main=   tetrinet client
  COMMENT-themes=       collection of gtetrinet themes
  DISTNAME=     gtetrinet-0.7.11
  PKGNAME-main= ${DISTNAME}
-REVISION-main= 17
+REVISION-main= 18
  PKGNAME-themes=       gtetrinet-themes-20070623
  REVISION-themes=2
  CATEGORIES=   x11 games
@@ -40,7 +40,7 @@ MODULES=              textproc/intltool \
  LIB_DEPENDS-main=     ${MODGCONF2_LIB_DEPENDS} \
                        x11/gnome/libgnome \
                        x11/gnome/libgnomeui \
-                       audio/esound>=0.2.38
+                       devel/libaudiofile
  LIB_DEPENDS-themes=
  WANTLIB-themes=
  RUN_DEPENDS-main=     ${RUN_DEPENDS} \
@@ -48,7 +48,7 @@ RUN_DEPENDS-main=     ${RUN_DEPENDS} \
  RUN_DEPENDS-themes=   games/gtetrinet
  PKG_ARCH-themes=      *

-WANTLIB-main += gnome-2 gnomeui-2 esd ${MODGCONF2_WANTLIB}
+WANTLIB-main += gnome-2 gnomeui-2 ${MODGCONF2_WANTLIB}
  WANTLIB-main += ICE ORBit-2 SM X11 Xau Xcomposite Xcursor Xdamage Xdmcp
  WANTLIB-main += Xext Xfixes Xi Xinerama Xrandr Xrender art_lgpl_2 atk-1.0
  WANTLIB-main += audiofile bonobo-2 bonobo-activation bonoboui-2 c cairo




--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

Reply via email to