On Jan 5, 2015 5:55 AM, Andrew Fresh <afre...@openbsd.org> wrote:
>
> On Sun, Jan 04, 2015 at 10:27:25PM +0100, Cesare Gargano wrote: 
> > On 2015-01-04 22:04, Andrew Fresh wrote: 
> > >On Sun, Jan 04, 2015 at 08:13:45PM +0100, Cesare Gargano wrote: 
> > >>Needed for upcoming update to www/p5-Plack (needed for upcoming 
> > >>www/p5-Dancer2). 
> > >> 
> > >>Tested on amd64. 
> > >> 
> > >>- 
> > >>pkg/DESCR: 
> > >>Compile a log format string to perl-code. For faster generation of 
> > >>access_log lines. 
> > > 
> > >This needs several more TEST_DEPENDS, other than that it looks fine. 
> > > 
> > >-TEST_DEPENDS = devel/p5-Test-MockTime 
> > >+TEST_DEPENDS = devel/p5-Test-MockTime>=0 \ 
> > >+               devel/p5-Test-Requires>=0 \ 
> > >+               devel/p5-Try-Tiny>=0.12 \ 
> > >+               www/p5-HTTP-Message>=0 \ 
> > >+               www/p5-URI>=1.60 
> > >+ 
> > > 
> > >l8rZ, 
> > 
> > Ok, attached is the right version. 
>
> This is much better.  Not sure how much of a stickler sthen@ is 
> about PERMIT_PACKAGE* coming before *_DEPENDS but that's the only nit I 
> see left to pick. 
>
> l8rZ, 
> -- 
> andrew - http://afresh1.com 
>
> I wish life had an UNDO function. 


PERMIT_PACKAGE* are _after_ *_DEPENDS. Am I wrong? 

Reply via email to