On 03/22/15 12:30, Adam Wolk wrote: > On Sun, Mar 22, 2015, at 05:25 AM, Brian Callahan wrote: >> Hi ports -- >> >> Attached is a new port, x11/walcommander. WalCommander is a free >> multi-platform orthodox file manager inspired by Far Manager. >> >> pkg/DESCR: >> WalCommander is a multi-platform open source orthodox file manager >> mimicking the look and feel of Far Manager. >> >> Features: >> * built-in terminal >> * built-in text editor with syntax highlighting >> * built-in text viewer >> * virtual file system (smb, ftp, sftp) >> * very fast user interface >> >> Works well on amd64. Upstream has been very good at accepting patches. >> >> OK? >> >> ~Brian >> >> Email had 1 attachment: >> + walcommander.tgz >> 2k (application/x-gtar) > Hi Brian, > > Tested on i386 snapshot from Mar 19. > Package installed & works, some notes below. > > 1) Leftover backup DESCR file in the tarball > walcommander/pkg/DESCR~
Blah. But at least that would be caught before import :-) > 2) make fetch failed on first attempt - was fine on the second try. I > don't know why it failed on the first time, network glitch on my system? I'm not github! :-) Probably just a hiccup. > $ make fetch > ===> Checking files for walcommander-0.19.0.1 >>> Fetch >>> https://github.com/corporateshark/WalCommander/archive/release-0.19.0.1/d5f32647f0ca069d5d02d99d6d46252819153604.tar.gz > ftp: connect: Address already in use >>> Fetch >>> http://ftp.openbsd.org/pub/OpenBSD/distfiles//d5f32647f0ca069d5d02d99d6d46252819153604.tar.gz > ftp: connect: Address already in use >>> Fetch >>> ftp://ftp.usa.openbsd.org/pub/OpenBSD/distfiles//d5f32647f0ca069d5d02d99d6d46252819153604.tar.gz > ftp: connect: Address already in use > ftp: Can't connect or login to host `ftp.usa.openbsd.org' >>> Fetch >>> http://ftp.fr.openbsd.org/pub/OpenBSD/distfiles//d5f32647f0ca069d5d02d99d6d46252819153604.tar.gz > ftp: Error retrieving file: 404 Not Found > *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2935 > '/usr/distfiles/WalCommander-0.19.0.1.tar.gz': > @lock=WalCommander-0.19.0.1.t...) > *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2307 > '_internal-fetch') > *** Error 1 in /usr/ports/mystuff/x11/walcommander > (/usr/ports/infrastructure/mk/bsd.port.mk:2473 'fetch') > $ > > 3) Is samba required for the port? Perhaps it would be worthwhile to > have a no samba flavour (not insisting on it though)? I thought about it but I didn't see it as super useful. You likely already have samba if you have a desktop system. It does do network share support if you have samba. Might be useful for someone. > 4) compilation warnings > cc -I swl -std=c++11 -c -D_FILE_OFFSET_BITS=64 -I /usr/local/include -O2 > -pipe -Wall -Wextra -Wno-unknown-pragmas -Wno-unused-parameter > -Wno-sign-compare -Wno-unused-variable -I wal -I swl -I > /usr/X11R6/include -I /usr/X11R6/include/freetype2 -D USEFREETYPE > -I/usr/src/contrib/libstdc++/include/backward -pthread > -Wno-unused-parameter -I src -I src/wal -I src/swl src/filesearch.cpp -o > obj/filesearch.o > In file included from src/vfs.h:14:0, > from src/fileopers.h:10, > from src/filesearch.h:9, > from src/filesearch.cpp:7: > src/globals.h:29:40: warning: 'unused' attribute ignored [-Wattributes] > # define UNUSED __attribute__ ((unused)) > ^ > src/filesearch.cpp:358:17: note: in expansion of macro 'UNUSED' > NCWin* m_NCWin UNUSED; > > > cc -I swl -std=c++11 -c -D_FILE_OFFSET_BITS=64 -I /usr/local/include -O2 > -pipe -Wall -Wextra -Wno-unknown-pragmas -Wno-unused-parameter > -Wno-sign-compare -Wno-unused-variable -I wal -I swl -I > /usr/X11R6/include -I /usr/X11R6/include/freetype2 -D USEFREETYPE > -I/usr/src/contrib/libstdc++/include/backward -pthread > -Wno-unused-parameter -I src -I src/wal -I src/swl src/vfs-sftp2.cpp -o > obj/vfs-sftp2.o > src/vfs-sftp2.cpp:153:26: warning: 'std::vector<char> CopyToStrZ(const > char*, int)' defined but not used [-Wunused-function] > static std::vector<char> CopyToStrZ( const char* s, int size ) > ^ > /usr/local/lib/libsmbclient.so.3.0: warning: random() may return > deterministic values, is that what you want? > obj/terminal.o(.text+0x9e): In function > `TerminalStream::TerminalStream()': > : warning: strcpy() is almost always misused, please use strlcpy() > /usr/X11R6/lib/libX11.so.16.0: warning: strcat() is almost always > misused, please use strlcat() > obj/filesearch.o(.text+0x3f): In function > `_ZL16SetStaticLineIntRN3wal10StaticLineEi': > : warning: sprintf() is often misused, please use snprintf() > /usr/local/lib/libwbclient.so.1.0: warning: rand() may return > deterministic values, is that what you want? I don't think that's anything to worry about. > 5) Is gcc4 needed? I only saw calls to cc which is the default 4.2.1 > compiler? Ah, except it's not a call to in-base cc. That's how ports works. You can tell that it's not using 4.2.1 since the -std=c++11 flag would error out if it was using the in-base cc. Yes, the gcc4 MODULE is needed. > 6) output on application quit (F10 quit) > $ wcm > ERR:'/usr/share/wcm/shl/config.cfg' (No such file or directory) > ERR:'/usr/share/wcm/shl/config.cfg' (No such file or directory) This is weird. Anyone else seeing this? I don't. > otter-browser:/usr/lib/libstdc++.so.57.0: Why is there a message from otter-browser here? > /usr/local/lib/libestdc++.so.16.0 : WARNING: > symbol(_ZN11__gnu_debug17_S_debug_messagesE) size mismatch, relink your > program > pthread_cond_destroy on condvar with waiters! > I see those elsewhere and as far as I know they're fine. ~Brian
