On Sat, Mar 28, 2015 at 02:20:34PM +0100, Theo Buehler wrote: > On Sat, Mar 28, 2015 at 12:03:06PM +0100, Christopher Zimmermann wrote: > > On Thu, 23 Oct 2014 13:16:52 +0200 Theo Buehler <t...@math.ethz.ch> > > wrote: > > > > > On Wed, Oct 22, 2014 at 04:45:26PM +0200, Pierre-Emmanuel André wrote: > > > > Hi, > > > > > > > > Small diff to update zsh to it's latest version. > > > > Tested on @amd64. > > > > > > > > Comments, ok ? > > > > Regards, > > > > > > > This looks good to me (also amd64). I've been running the updated > > > shell for about a day now and didn't encounter any issues. > > > > > > Two comments: > > > > > > 1. I went through the entire list on the ports testing guide and > > > almost everything seems to be fine. There still is this spurious > > > failure of ``make test'' which ends with > > > > > > ************************************** > > > 42 successful test scripts, 1 failure, 0 skipped > > > ************************************** > > > *** Error 1 in Test (Makefile:204 'check') > > > *** Error 1 in /usr/obj/ports/zsh-5.0.7/zsh-5.0.7 (Makefile:265 > > > 'check') *** Error 1 in . > > > (/usr/ports/infrastructure/mk/bsd.port.mk:2801 > > > '/usr/obj/ports/zsh-5.0.7/.test_done') *** Error 1 > > > in /usr/ports/shells/zsh > > > (/usr/ports/infrastructure/mk/bsd.port.mk:2492 'test') > > > > > > after indicating that _all_ tests passed successfully. This bizarre > > > brekage has been around for a while now. > > > > > > > > > 2. The following simple patch fixes a compiler warning in > > > Src/Modules/langinfo.c > > > > > > Hi, > > > > below you find a diff with the compiler warning fix included. I'm ok > > with committing Pierre's original diff with or without this fix. > > > > Hi, > > Thanks for reminding me of this. Your patch works fine for me. I've > been running this patch for five months now with no issues worth > mentioning. > > I have no strong opinion about whether to include my minor patch or not. > I just reported the compiler warning upstream > > http://www.zsh.org/mla/workers/2015/msg00716.html > > so hopefully this will be fixed in the next zsh release anyway. > > Theo >
Hi, Is there any chance that this updated port will be committed soon or is there anything wrong with it? I'd really appreciate some news. Thanks in advance, Theo
