On Sun, May 03, 2015 at 03:35:15PM +0200, albat0...@wanadoo.fr wrote: > Hi, > > Here is a sum up of the diff: > > - Source 2.1.3 instead of 2.0.4 (a jump of 19 months). > > - Inclusion of libmagic (thanks Josh Grosse for pointed that > out). The port can build without but port-lib-depends-check > stumbles on it and the RELEASE-NOTES mentions it improves the file > format detection. > > - Mirror list against those on the official site. > > - Removal of unknown configure options: without-aiksaurus and > enable-threads=posix (replaced by with-packaging=posix). > > - Usage of QT4DIR to find moc and iuc binaries. > > This was tested on amd64 and i386. Is there anyone to have a go on > powerpc and sparc64 (better backup ~/.lyx) and/or commit it? > # pkg_info lyx|grep Maintainer > Maintainer: The OpenBSD ports mailing-list <ports@openbsd.org>
Minor nits: EXTRACT_SUFX defaults to .tar.gz so you shouldnt need it, and empty REVISION isnt needed either. You shouldnt remove @pkgpath annotations on the top, nor the @exec lines at the bottom. Since you add icons in /hicolor/ a RUN_DEPENDS on desktop-file-utils should be added, and the corresponding @exec annotations after the update-desktop-database ones. Other than that it generally looks good. Landry
