On 2015/07/31 15:53, Tobias Ulmer wrote:
> Is David around? Any objections should be voiced in the next few hours,
> before I commit this.
It's actually libtorrent not rtorrent that should be marked broken.
Would it be worth building on i386 with compiler flags to fix that,
at the expense of not running on crappy old machines that you probably
wouldn't want to run this on anyway?
Index: libtorrent/Makefile
===================================================================
RCS file: /cvs/ports/net/libtorrent/Makefile,v
retrieving revision 1.40
diff -u -p -r1.40 Makefile
--- libtorrent/Makefile 24 Mar 2015 13:35:09 -0000 1.40
+++ libtorrent/Makefile 31 Jul 2015 14:31:14 -0000
@@ -2,6 +2,10 @@
COMMENT= BitTorrent library written in C++
+BROKEN-hppa = undefined references to __sync atomic ops
+BROKEN-mips64 = undefined references to __sync atomic ops
+BROKEN-sh = undefined references to __sync atomic ops
+
# requires C++ tr1 headers
NOT_FOR_ARCHS= ${GCC3_ARCHS}
@@ -28,5 +32,13 @@ CONFIGURE_ARGS= ${CONFIGURE_SHARED} \
--with-kqueue \
--without-epoll \
--disable-debug
+
+.include <bsd.port.arch.mk>
+
+# for 64-bit atomic ops
+.if ${ARCH:Mi386}
+CFLAGS+= -march=i586 -fomit-frame-pointer
+CXXFLAGS+= -march=i586 -fomit-frame-pointer
+.endif
.include <bsd.port.mk>
Index: rtorrent/Makefile
===================================================================
RCS file: /cvs/ports/net/rtorrent/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- rtorrent/Makefile 28 May 2015 10:17:24 -0000 1.48
+++ rtorrent/Makefile 31 Jul 2015 14:31:25 -0000
@@ -1,10 +1,5 @@
# $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $
-BROKEN-hppa = undefined references to __sync atomic ops
-BROKEN-mips64 = undefined references to __sync atomic ops
-BROKEN-sh = undefined references to __sync atomic ops
-BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch)
-
COMMENT= ncurses BitTorrent client based on libTorrent
DISTNAME= rtorrent-0.9.4
