On Thu Aug 13, 2015 at 10:37:34PM +0300, Vadim Zhukov wrote: > 2015-08-13 22:10 GMT+03:00 Rafael Sadowski <raf...@sizeofvoid.org>: > > Hi ports@, > > > > after frequently requests from the OpenBSD community here is a stable > > version/port. Tested @amd64. > > > > $ cat pkg/DESCR > > x2goclient is a GUI application for launching server-side X2Go sessions. > > > > Ok(s)? >
Thanks for your review! > 1. PKGNAME is not needed since it's the same with DISTNAME. fixed; > > 2. In the x2goclient.pro patch, you'd better use $(X11BASE)/include > instead of hardcoding /usr/X11R6/include. > fixed; > 3. No need to separate pre-configure and do-configure targets. The > pre-configure should be used when you want some default configure code > to work, but do-configure overrides it. of course, fixed; > > 4. It probably worths installing some more documentation, since the > manual page looks like more an options summary than a manual. But I > could not insist here on anything since I'm not a user of this > software. > trust me, there is no more documentation necessary.