Donovan Watteau <[email protected]> writes:

> On Sat, 29 Aug 2015, Stuart Henderson wrote:
>> On 2015/08/29 11:16, Donovan Watteau wrote:
>> > Hi,
>> > 
>> > Here's a new port for libdiscid, which my next audio/cmus update
>> > will use.
>> > 
>> > I tried cleaning some strcpy(), strcat() and sprintf().  "make test"
>> > is still fine.  If patch-src_disc_c looks good to you, I'll submit it
>> > to upstream.
>> > 
>> > Tested on macppc.
>> 
>> Upstream will need some glue to make that work on OS with deficient
>> versions of libc. In most cases we don't add this type of patch in ports
>> as it often gets in the way of updates, but feeding upstream (if they'll
>> take it) is good.
>
> Yes, I was working on submitting it to upstream with all the necessary
> libc glue, but OK.
>
> So here's the port again, without the patch.

Looks fine to me, two nits:

1.
CONFIGURE_ENV=  CPPFLAGS="-I${LOCALBASE}/include" \
                LDFLAGS="-L${LOCALBASE}/lib" \
                ac_cv_header_musicbrainz5_mb5_c_h=no

If there is no dep on other packages then there is no need to tweak
CPP/LDFLAGS.  And if usr/local isn't in those flags,
ac_cv_header_musicbrainz5_mb5_c_h=no is not needed (but you may want to
keep it for documentation).

2. Any idea why two tests out of four are skipped?

===>  Cleaning for libdiscid-0.6.1
===>  Checking files for libdiscid-0.6.1
`/home/distfiles/libdiscid-0.6.1.tar.gz' is up to date.
>> (SHA256) libdiscid-0.6.1.tar.gz: OK
===>  Extracting for libdiscid-0.6.1
===>  Patching for libdiscid-0.6.1
===>  Configuring for libdiscid-0.6.1
Using /usr/obj/pobj/libdiscid-0.6.1/config.site (generated)
configure: WARNING: unrecognized options: --disable-gtk-doc
configure: loading site script /usr/obj/pobj/libdiscid-0.6.1/config.site
checking for a BSD-compatible install... 
/usr/obj/pobj/libdiscid-0.6.1/bin/install -c 
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... mkdir -p
checking for gawk... (cached) awk
checking whether make sets $(MAKE)... (cached) yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... cc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... (cached) o
checking whether we are using the GNU C compiler... (cached) yes
checking whether cc accepts -g... (cached) yes
checking for cc option to accept ISO C89... none needed
checking whether cc understands -c and -o together... yes
checking dependency style of cc... gcc3
checking for ar... (cached) ar
checking the archiver (ar) interface... ar
checking build system type... x86_64-unknown-openbsd5.8
checking host system type... x86_64-unknown-openbsd5.8
configure: Using disc read implementation for: netbsd
checking how to print strings... print -r
checking for a sed that does not truncate output... (cached) /usr/bin/sed
checking for grep that handles long lines and -e... (cached) /usr/bin/grep
checking for egrep... (cached) /usr/bin/egrep
checking for fgrep... (cached) /usr/bin/fgrep
checking for ld used by cc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... (cached) 131072
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... no
checking how to convert x86_64-unknown-openbsd5.8 file names to 
x86_64-unknown-openbsd5.8 format... func_convert_file_noop
checking how to convert x86_64-unknown-openbsd5.8 file names to toolchain 
format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... match_pattern 
/lib[^/]+(\.so\.[0-9]+\.[0-9]+|\.so|_pic\.a)$
checking for dlltool... no
checking how to associate runtime and link libraries... print -r --
checking for archiver @FILE support... @
checking for strip... (cached) strip
checking for ranlib... (cached) ranlib
checking command to parse /usr/bin/nm -B output from cc object... ok
checking for sysroot... no
checking for mt... mt
checking if mt is a manifest tool... no
checking how to run the C preprocessor... cc -E
checking for ANSI C header files... (cached) yes
checking for sys/types.h... (cached) yes
checking for sys/stat.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for memory.h... (cached) yes
checking for strings.h... (cached) yes
checking for inttypes.h... (cached) yes
checking for stdint.h... (cached) yes
checking for unistd.h... (cached) yes
checking for dlfcn.h... (cached) yes
checking for objdir... .libs
checking if cc supports -fno-rtti -fno-exceptions... no
checking for cc option to produce PIC... -fPIC -DPIC
checking if cc PIC flag -fPIC -DPIC works... yes
checking if cc static flag -static works... yes
checking if cc supports -c -o file.o... yes
checking if cc supports -c -o file.o... (cached) yes
checking whether the cc linker (/usr/bin/ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... yes
checking dynamic linker characteristics... openbsd5.8 ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for windres... no
checking for gcc... (cached) cc
checking whether we are using the GNU C compiler... (cached) yes
checking whether cc accepts -g... (cached) yes
checking for cc option to accept ISO C89... (cached) none needed
checking whether cc understands -c and -o together... (cached) yes
checking dependency style of cc... (cached) gcc3
checking whether byte ordering is bigendian... no
checking size of long... 8
checking whether make supports nested variables... (cached) yes
checking for musicbrainz5/mb5_c.h... (cached) no
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libdiscid.pc
config.status: creating versioninfo.rc
config.status: creating Doxyfile
config.status: creating include/discid/discid.h
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
configure: WARNING: unrecognized options: --disable-gtk-doc
===>  Building for libdiscid-0.6.1
make  all-am
depbase=`echo src/base64.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; 
/usr/bin/libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/base64.lo -MD -MP -MF $depbase.Tpo -c 
-o src/base64.lo /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/base64.c && 
mv -f $depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/base64.lo -MD -MP -MF 
src/.deps/base64.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/base64.c -fPIC -DPIC -o 
src/.libs/base64.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/base64.lo -MD -MP -MF 
src/.deps/base64.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/base64.c -o src/base64.o
depbase=`echo src/sha1.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; 
/usr/bin/libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/sha1.lo -MD -MP -MF $depbase.Tpo -c -o 
src/sha1.lo /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/sha1.c && mv -f 
$depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/sha1.lo -MD -MP -MF src/.deps/sha1.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/sha1.c -fPIC -DPIC -o 
src/.libs/sha1.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/sha1.lo -MD -MP -MF src/.deps/sha1.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/sha1.c -o src/sha1.o
depbase=`echo src/disc.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; 
/usr/bin/libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/disc.lo -MD -MP -MF $depbase.Tpo -c -o 
src/disc.lo /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc.c && mv -f 
$depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/disc.lo -MD -MP -MF src/.deps/disc.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc.c -fPIC -DPIC -o 
src/.libs/disc.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/disc.lo -MD -MP -MF src/.deps/disc.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc.c -o src/disc.o
depbase=`echo src/toc.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; /usr/bin/libtool 
 --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/toc.lo -MD -MP -MF $depbase.Tpo -c -o 
src/toc.lo /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/toc.c && mv -f 
$depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/toc.lo -MD -MP -MF src/.deps/toc.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/toc.c -fPIC -DPIC -o 
src/.libs/toc.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/toc.lo -MD -MP -MF src/.deps/toc.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/toc.c -o src/toc.o
depbase=`echo src/unix.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; 
/usr/bin/libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/unix.lo -MD -MP -MF $depbase.Tpo -c -o 
src/unix.lo /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/unix.c && mv -f 
$depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/unix.lo -MD -MP -MF src/.deps/unix.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/unix.c -fPIC -DPIC -o 
src/.libs/unix.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/unix.lo -MD -MP -MF src/.deps/unix.Tpo 
-c /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/unix.c -o src/unix.o
depbase=`echo src/disc_netbsd.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`; 
/usr/bin/libtool  --tag=CC    --mode=compile cc -DHAVE_CONFIG_H  -I. 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include   -O2 -pipe -MT src/disc_netbsd.lo -MD -MP -MF 
$depbase.Tpo -c -o src/disc_netbsd.lo 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc_netbsd.c && mv -f 
$depbase.Tpo $depbase.Plo
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/disc_netbsd.lo -MD -MP -MF 
src/.deps/disc_netbsd.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc_netbsd.c -fPIC -DPIC -o 
src/.libs/disc_netbsd.o
cc -DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1 
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include 
-I/usr/local/include -O2 -pipe -MT src/disc_netbsd.lo -MD -MP -MF 
src/.deps/disc_netbsd.Tpo -c 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/src/disc_netbsd.c -o 
src/disc_netbsd.o
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe  -version-number 0:6:1  
-no-undefined  -L/usr/local/lib -o libdiscid.la -rpath /usr/local/lib 
src/base64.lo src/sha1.lo src/disc.lo       src/toc.lo src/unix.lo  
src/disc_netbsd.lo     
libtool: link: cc -shared -fPIC -DPIC -o .libs/libdiscid.so.0.0 -O2 -pipe 
src/.libs/base64.o src/.libs/sha1.o src/.libs/disc.o src/.libs/toc.o 
src/.libs/unix.o src/.libs/disc_netbsd.o
libtool: link: ar cru .libs/libdiscid.a src/base64.o src/sha1.o src/disc.o 
src/toc.o src/unix.o src/disc_netbsd.o
libtool: link: ranlib .libs/libdiscid.a
depbase=`echo examples/discid.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT examples/discid.o -MD -MP -MF $depbase.Tpo 
-c -o examples/discid.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/examples/discid.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
discid examples/discid.o ./libdiscid.la 
libtool: link: cc -o .libs/discid -O2 -pipe examples/discid.o -L.libs -ldiscid 
-Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
depbase=`echo examples/discisrc.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT examples/discisrc.o -MD -MP -MF 
$depbase.Tpo -c -o examples/discisrc.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/examples/discisrc.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
discisrc examples/discisrc.o ./libdiscid.la 
libtool: link: cc -o .libs/discisrc -O2 -pipe examples/discisrc.o -L.libs 
-ldiscid -Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
===>  Regression tests for libdiscid-0.6.1
make  test_core test_put  test_read test_read_full
depbase=`echo test/test.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT test/test.o -MD -MP -MF $depbase.Tpo -c -o 
test/test.o /usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/test/test.c && mv -f 
$depbase.Tpo $depbase.Po
depbase=`echo test/test_core.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT test/test_core.o -MD -MP -MF $depbase.Tpo 
-c -o test/test_core.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/test/test_core.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
test_core test/test.o test/test_core.o ./libdiscid.la 
libtool: link: cc -o .libs/test_core -O2 -pipe test/test.o test/test_core.o 
-L.libs -ldiscid -Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
depbase=`echo test/test_put.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT test/test_put.o -MD -MP -MF $depbase.Tpo -c 
-o test/test_put.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/test/test_put.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
test_put test/test.o test/test_put.o ./libdiscid.la 
libtool: link: cc -o .libs/test_put -O2 -pipe test/test.o test/test_put.o 
-L.libs -ldiscid -Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
depbase=`echo test/test_read.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT test/test_read.o -MD -MP -MF $depbase.Tpo 
-c -o test/test_read.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/test/test_read.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
test_read test/test.o test/test_read.o ./libdiscid.la 
libtool: link: cc -o .libs/test_read -O2 -pipe test/test.o test/test_read.o 
-L.libs -ldiscid -Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
depbase=`echo test/test_read_full.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`; cc 
-DHAVE_CONFIG_H -I. -I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1  
-I/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/include -I./include  
-I/usr/local/include  -O2 -pipe -MT test/test_read_full.o -MD -MP -MF 
$depbase.Tpo -c -o test/test_read_full.o 
/usr/obj/pobj/libdiscid-0.6.1/libdiscid-0.6.1/test/test_read_full.c && mv -f 
$depbase.Tpo $depbase.Po
/usr/bin/libtool  --tag=CC    --mode=link cc  -O2 -pipe   -L/usr/local/lib -o 
test_read_full test/test.o  test/test_read_full.o ./libdiscid.la 
libtool: link: cc -o .libs/test_read_full -O2 -pipe test/test.o 
test/test_read_full.o -L.libs -ldiscid -Wl,-rpath-link,/usr/local/lib
.libs/libdiscid.so.0.0: warning: warning: strcpy() is almost always misused, 
please use strlcpy()
.libs/libdiscid.so.0.0: warning: warning: strcat() is almost always misused, 
please use strlcat()
.libs/libdiscid.so.0.0: warning: warning: sprintf() is often misused, please 
use snprintf()
make  check-TESTS
PASS: test_core
PASS: test_put
SKIP: test_read
SKIP: test_read_full
make  all-am
============================================================================
Testsuite summary for libdiscid 0.6.1
============================================================================
# TOTAL: 4
# PASS:  2
# SKIP:  2
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to