On Thu, Nov 12, 2015 at 11:24:20AM +0000, Stuart Henderson wrote:
> > > I considered something like this too, but it didn't overall feel quite
> > > right - we need a way to set the script name anyway (even without
> > > autoreconf -fi the names vary), and I'm trying to avoid too much use
> > > of the word "autogen" to avoid confusion with devel/autogen.
> >
> > Now that you mention it, I don't think this is such a bad idea actually.
> > We could have:
> > CONFIGURE_STYLE = autogen (runs ./autogen.sh)
> > CONFIGURE_STYLE = autoreconf (run autoreconf -fi)
> >
> > But I'm not opposed to your way.
> >
> > I am really happy someone actually moved on that :-)
>
> hmm, let's look at a sample of what's in tree already (not all of them).
Well there will always be exceptions of course :-)
I am pretty sure some of these could be converted to autoreconf -fi and some
may actually bundle an autogen.sh script which was missed/unused at the time of
porting.
> archivers/par2cmdline/Makefile:37- aclocal; automake --add-missing;
> autoconf
> audio/faad/Makefile:71- sh bootstrap
> audio/timidity/Makefile:71- AUTOMAKE_VERSION=${AUTOMAKE_VERSION}
> aclocal -I autoconf
> audio/swh-plugins/Makefile:47- cd ${WRKSRC}; ${AUTO_ENV} aclocal -I . -I m4
> audio/mp3blaster/Makefile:38- @cd ${WRKSRC}; ${AUTO_ENV} aclocal
> audio/jack/Makefile:63- cd ${WRKSRC}; ${AUTO_ENV} aclocal
> audio/jack/Makefile:66- cd ${WRKSRC}; ${AUTO_ENV} automake --add-missing
> --foreign
> comms/tlf/Makefile:36- autoreconf --install
> devel/hyena/Makefile:39- AUTOMAKE_VERSION=${AUTOMAKE_VERSION}
> aclocal -I build/m4/shamrock
> devel/ois/Makefile:45- AUTOMAKE_VERSION=${AUTOMAKE_VERSION} sh
> ./bootstrap
> games/numptyphysics/Makefile:57-
> AUTOMAKE_VERSION=${AUTOMAKE_VERSION} aclocal
> geo/osm-gps-map/Makefile:56- NOCONFIGURE=yes ./autogen.sh
I think you want to add 'NOCONFIGURE=yes' by default in your diff.
> graphics/libpgf/Makefile:39- sh autogen.sh
> lang/fsharp/Makefile:38- AUTOMAKE_VERSION=${AUTOMAKE_VERSION}
> ./autogen.sh --prefix=${LOCALBASE}
> multimedia/transcode/Makefile:129-
> AUTOMAKE_VERSION=${AUTOMAKE_VERSION} autoreconf -if
> security/yara/main/Makefile:20- AUTOCONF_VERSION=${AUTOCONF_VERSION}
> ./bootstrap.sh
>
> so some different filenames, various direct auto* / aclocal invocations,
> some aren't executable (or maybe use bash) and need sh ..
>
> Perhaps match on something like 'CONFIGURE_STYLE= gnu gen' and set
> 'MODGNU_GEN?=sh autogen.sh' but still allow it to be overridden?
> (Or s/gen/generate/ for a more self-explanatory string but more to
> type).
>
> Other input definitely welcome.
How is FreeBSD coping with this?
--
Antoine
