On Thu, Nov 26, 2015 at 12:51:41PM +0100, Joerg Jung wrote:
> On Thu, Nov 26, 2015 at 12:13:44PM +0100, Landry Breuil wrote:
> > On Thu, Nov 26, 2015 at 12:01:02PM +0100, Joerg Jung wrote:
> > > On Wed, Nov 25, 2015 at 02:23:47PM +0100, Joerg Jung wrote:
> > > >
> > > > please find below an update for opensmtpd-extras to the most recent
> > > > snapshot. This also now installs table-ldap, table-passwd, and
> > > > table-sqlite which are likely going to be removed from base soon.
> > >
> > > Please find below a tweaked diff after some input from Giovanni.
> >
> > Sorry, but this doesnt make sense.
> >
> > You have a MULTI_PACKAGES port without FLAVORs, why do you go through
> > the headache of .if ${BUILD_PACKAGES} sections ? To avoid kicking off
> > the port on some useless arch nobody will ever run smtpd-extras on ?
> > You dont have FLAVORs nor PSEUDO_FLAVORS, just merge all
> > CONFIGURE_ARGS/MODULES...
>
> Thanks for your feedback! I merged them as suggested, updated diff below.
>
> > PREFIX=/usr still looks wrong but i understand that you'll have to reach
> > opensmtpd upstream to make them look into /usr/local :)
>
> Yes. Last time Gilles did not liked this and I understand why. This
> might need to be re-discussed at some point (when other more important
> todos are done in smtpd). But for now it should not be show-stopper, as
> just kept/handled in the same way as before.
>
I must have misunderstood, what I don't like is that we introduce a knob
to the config file to specify where we should look them up.
we have a libexec path which is used for stuff like mail.local and if we
keep the convention that filters / queues / schedulers are installed in
libexec and follow a certain naming convention then we don't need a knob
at all.
now, i'm not opposed to looking in libexec in /usr/local then /usr, this
would still not require a knob.
--
Gilles Chehade
https://www.poolp.org @poolpOrg
