Hi, Stuart Henderson <st...@openbsd.org> writes:
> On 2015/12/10 22:39, Rafael Sadowski wrote: >> On Thu Dec 10, 2015 at 10:01:46AM +0000, Stuart Henderson wrote: >> > On 2015/12/09 19:09, Jérémie Courrèges-Anglas wrote: >> > > >> - Don't use own libmd5 but base md5 >> > > >> - Use MD5Data() instead of MD5Buffer+MD5SigToString >> > > >> > > What is the point with those two items? This adds clutter to this >> > > update and possible problems for the following ones. >> > >> > These changes are exactly why I, for one, didn't dig into the update yet. >> >> Of course I understand you but I don't like to use doxygen own libmd5. >> md5(3) is in base and MD5Data is doing the same as MD5Buffer+MD5SigToString. >> >> I've learned[1] to use base and ports libs and not own shipped libs if it >> is possible. >> >> [1]: https://www.marc.info/?l=openbsd-ports&m=142177625024026&w=4 > > That's a different situation, in that case they are bundling entire > libraries which we already have in ports. That's usually bad because > when some bug is fixed in the library, it doesn't then get fixed in > the embedded versions of that library. And it's not like the API used in the port is exactly the same as the one available in base. >> It's okay for me to remove the patches and test agine. Please do. I don't think another full round of tests is needed. Cheers, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
