On Fri, Feb 05, 2016 at 12:55:49PM +0100, Dmitrij D. Czarkoff wrote: > Vadim Zhukov said: > > 2016-02-05 2:03 GMT+03:00 Dmitrij D. Czarkoff <czark...@gmail.com>: > > > Michael Seyfert said: > > >> I'm trying to get this into the ports tree yet again. > > >> > > >> MOC is a console audio player with simple ncurses interface. It > > >> supports OGG, WAV, MP3 and other formats. Just run mocp, go to some > > >> directory using the menu and press enter to start playing the file. > > >> The program will automatically play the rest of the files in the > > >> directory. > > > > > > I added a patch to use file(1) instead of libmagic and marked this port > > > as SHARED_ONLY. > > > > > > Comments? OKs? > > > > Why not just use fork+exec, without need to care about escaping anymore? > > This version uses fork+execl. FWIW I am getting convinced that just > disabling this functionality is the best approach: it is basically used > for detecting music files with wrong filename suffixes. Very few > legitimate use cases for this are better handled through renaming files. > > P.S.: As is pretty obvious from previous messages in this thread, I > have little experience with exec and friends in C. I'd appreciate > feedback. > > -- > Dmitrij D. Czarkoff
The option UseMimeMagic is false by default so that code is not used unless the user specifies it. libmagic / file is not needed. -- Michael Seyfert <mich...@codesand.org>
