On Mon, Feb 15, 2016 at 09:47:54PM +0000, Pedro de Oliveira wrote:
> Hi again,
> 
> Here is an updated version, with two patches from github, it now also
> passes portcheck.
> I believe that in the next version both patches will already be in upstream.
> 
> https://github.com/hishamhm/htop/pull/398
> https://github.com/hishamhm/htop/pull/376

I've attached an updated version of your port. You forgot to
double-check some parts :)

> 
> On Sun, Feb 14, 2016 at 10:08 PM, Juan Francisco Cantero Hurtado
> <i...@juanfra.info> wrote:
> > On Thu, Feb 11, 2016 at 08:53:42PM -0500, Michael McConville wrote:
> >> Pedro de Oliveira wrote:
> >> > Hi,
> >> >
> >> > Attached is a new port for sysutils/htop.The new 2.0.0 release now
> >> > supports OpenBSD.
> >> > It's my first port, so be easy!
> >> >
> >> > Any comments? OK to import?
> >> >
> >> > Regards,
> >> > Pedro de Oliveira
> >>
> >> Hi, Pedro.
> >>
> >> I wrote the OpenBSD-specific htop code. I was planning on making a
> >> proper port ASAP; thanks for beating me to it!  :-)  I'll try to review
> >> it this weekend.
> >>
> >> It's too late to get it into 5.9, sadly. This gives us more time to
> >> improve the OS-specific code, though.
> >>
> >> If you want to help with that, you could review and test this patch by
> >> juanfra@:
> >>
> >> https://github.com/hishamhm/htop/pull/376
> >
> > I've seeing a bunch of double-free and use-after-free in htop. Please,
> > run your tests with "MALLOC_OPTIONS=CFGJU htop" and fix the code
> > yourself in the upstream github repo if you can.


-- 
Juan Francisco Cantero Hurtado http://juanfra.info

Attachment: htop.tgz
Description: GNU Unix tar archive

Reply via email to