On 03/09/16 15:47, Joerg Jung wrote:

Am 09.03.2016 um 01:59 schrieb Michael Reed <m.r...@mykolab.com>:

I prefer terminus font, but I don't see why this is listed as a
dependency; the system monospace font, DejaVu, works fine with dmenu.

If the user likes terminus font then they can install it and use it w/
dmenu, but otherwise it's just an unneeded dependency.

This was discussed several times before. The short summary of the
current situation is: since some years all of our "suckless ports" contain
various minor tweaks to make them look similar when used together,
including for example: same terminus font and sizes, same grey color
scheme, similar key bindings, prefer base tools over ports (e.g. curl vs
ftp in surf), etc, yalla, yalla...

So they are all not really vanilla because some devs (including me)
prefer to have a sane desktop look'n feel. Your change below makes
sense but should be applied to other suckless ports as well... BUT
at least tabbed does not (yet) have xft support (already committed
in HEAD but not released) and thus would look badly and not unified
then. So for now, I'm still (slightly) against this diff.

Thanks for the explanation; I've attached a new patch. At least in the x11/ folder, dwm was the only port still using terminus, besides tabbed.

If you'd still like to wait until tabbed has a new release, I can resend an updated patch then.
? dmenu/no_terminus.diff
Index: dwm/Makefile
===================================================================
RCS file: /cvs/ports/x11/dwm/Makefile,v
retrieving revision 1.27
diff -u -p -r1.27 Makefile
--- dwm/Makefile	11 Nov 2015 09:27:13 -0000	1.27
+++ dwm/Makefile	9 Mar 2016 21:28:32 -0000
@@ -3,6 +3,7 @@
 COMMENT=		dynamic window manager
 
 DISTNAME=		dwm-6.1
+REVISION=		0
 
 CATEGORIES=		x11
 
@@ -17,8 +18,7 @@ WANTLIB=		X11 Xinerama c Xft fontconfig
 
 MASTER_SITES=		http://dl.suckless.org/dwm/
 
-RUN_DEPENDS=		x11/dmenu>=4.6 \
-			fonts/terminus-font
+RUN_DEPENDS=		x11/dmenu>=4.6
 
 MAKE_ENV=		LDFLAGS="${LDFLAGS}"
 FAKE_FLAGS=		DESTDIR=""
Index: dwm/patches/patch-config_def_h
===================================================================
RCS file: /cvs/ports/x11/dwm/patches/patch-config_def_h,v
retrieving revision 1.11
diff -u -p -r1.11 patch-config_def_h
--- dwm/patches/patch-config_def_h	11 Nov 2015 09:27:13 -0000	1.11
+++ dwm/patches/patch-config_def_h	9 Mar 2016 21:28:32 -0000
@@ -1,12 +1,9 @@
 $OpenBSD: patch-config_def_h,v 1.11 2015/11/11 09:27:13 jung Exp $
---- config.def.h.orig	Sun Nov  8 23:39:37 2015
-+++ config.def.h	Wed Nov 11 09:50:09 2015
-@@ -2,15 +2,15 @@
- 
- /* appearance */
+--- config.def.h.orig	Sun Nov  8 17:39:37 2015
++++ config.def.h	Wed Mar  9 16:22:13 2016
+@@ -4,13 +4,13 @@
  static const char *fonts[] = {
--	"monospace:size=10"
-+	"terminus:size=8"
+ 	"monospace:size=10"
  };
 -static const char dmenufont[]       = "monospace:size=10";
 -static const char normbordercolor[] = "#444444";
Index: dmenu/Makefile
===================================================================
RCS file: /cvs/ports/x11/dmenu/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- dmenu/Makefile	11 Nov 2015 09:23:19 -0000	1.21
+++ dmenu/Makefile	9 Mar 2016 21:28:32 -0000
@@ -2,6 +2,7 @@
 
 COMMENT=		dynamic menu for X11
 DISTNAME=		dmenu-4.6
+REVISION=		0
 
 CATEGORIES=		x11
 HOMEPAGE=		http://tools.suckless.org/dmenu
@@ -14,8 +15,6 @@ PERMIT_PACKAGE_CDROM=	Yes
 WANTLIB=		X11 Xinerama c Xft fontconfig
 
 MASTER_SITES=		http://dl.suckless.org/tools/
-
-RUN_DEPENDS=		fonts/terminus-font
 
 FAKE_FLAGS=		DESTDIR=""
 
Index: dmenu/patches/patch-config_def_h
===================================================================
RCS file: /cvs/ports/x11/dmenu/patches/patch-config_def_h,v
retrieving revision 1.1
diff -u -p -r1.1 patch-config_def_h
--- dmenu/patches/patch-config_def_h	11 Nov 2015 09:23:20 -0000	1.1
+++ dmenu/patches/patch-config_def_h	9 Mar 2016 21:28:32 -0000
@@ -1,12 +1,8 @@
 $OpenBSD: patch-config_def_h,v 1.1 2015/11/11 09:23:20 jung Exp $
---- config.def.h.orig	Sun Nov  8 23:42:21 2015
-+++ config.def.h	Wed Nov 11 09:43:27 2015
-@@ -4,13 +4,13 @@
- static int topbar = 1;                      /* -b  option; if 0, dmenu appears at bottom     */
- /* -fn option overrides fonts[0]; default X11 font or font set */
- static const char *fonts[] = {
--	"monospace:size=10"
-+	"terminus:size=8"
+--- config.def.h.orig	Sun Nov  8 17:42:21 2015
++++ config.def.h	Fri Feb 19 15:10:11 2016
+@@ -7,10 +7,10 @@ static const char *fonts[] = {
+ 	"monospace:size=10"
  };
  static const char *prompt      = NULL;      /* -p  option; prompt to the elft of input field */
 -static const char *normbgcolor = "#222222"; /* -nb option; normal background                 */

Reply via email to