On 2016/04/18 13:27, Christopher Zimmermann wrote:
> Hi,
> 
> ion3 has been abandoned by its upstream developer. It has been forked
> on github and is now named notion. Here's a diff for upgrading to the
> latest version of notion and changing the ports name to notion, which
> is required by a special license clause in original ion3. ok?
> 
> Christopher
> 
> 
> diff -Nru ion/Makefile notion/Makefile
> --- ion/Makefile      Mon Mar 28 19:47:27 2016
> +++ notion/Makefile   Mon Apr 18 12:53:46 2016

This is a bit of an awkward thing to send as a diff. A new tar would be
better.

> @@ -1,31 +1,36 @@
>  # $OpenBSD: Makefile,v 1.63 2016/03/27 20:53:15 naddy Exp $
>  
> -COMMENT=     light, keyboard friendly window manager
> +COMMENT =    static tiling, tabbing and floating window manager
>  
> -V=           20090110
> -DISTNAME=    ion-3-${V}
> -PKGNAME=     ion-${V}
> -CATEGORIES=  x11
> -REVISION=    2
> +CATEGORIES = x11
>  
> -HOMEPAGE=    http://modeemi.cs.tut.fi/~tuomov/ion/
> -MASTER_SITES=        http://tuomov.iki.fi/software/dl/
> +GH_TAGNAME = 3-2015061300
> +GH_ACCOUNT =    raboof
> +GH_PROJECT =    notion
> +DISTNAME =      ${GH_PROJECT}-${GH_TAGNAME}
> +PKGNAME =    ${GH_PROJECT}-${GH_TAGNAME:S/-/./}

tabs/spaces issue in some of these lines.


> +HOMEPAGE =   http://notion.sourceforge.net/
> +
>  # LGPL
>  PERMIT_PACKAGE_CDROM=        Yes
>  
> -WANTLIB=     ICE X11 m c SM Xext ${MODLUA_WANTLIB}
> -
> -MODULES=     devel/gettext \
> +MODULES =    devel/gettext \
>               lang/lua
> -MODLUA_SA=   Yes
>  
> -LIB_DEPENDS= ${MODLUA_LIB_DEPENDS}
> +WANTLIB =    ICE m c SM X11 Xext Xinerama Xrandr ${MODLUA_WANTLIB}

WANTLIB goes just after PERMIT_*.

> -USE_GMAKE=   Yes
> -NO_TEST=     Yes
> +#MODLUA_SA = Yes

why # this out? it should stay as-is, see port-modules(5).

> +#pre-configure:
> +#    ${SUBST_CMD} ${WRKSRC}/system-autodetect.mk

either remove this or remove the #'s.

> diff -Nru ion/pkg/PLIST notion/pkg/PLIST
> --- ion/pkg/PLIST       Mon Mar 28 19:47:27 2016
> +++ notion/pkg/PLIST    Wed Mar 30 14:30:49 2016

missing @pkgpath if you're trying to get it to update automatically (and
you'll need a devel/quirka entry for that too).

Reply via email to