Jeremie Courreges-Anglas <j...@wxcvbn.org> writes: > timo.my...@wickedbsd.net (Timo Myyrä) writes: > >> Hi, > > Hi, > >> Here is an port of lightweight notification daemon. >> I'm using with i3 window manager and it seems to work for my needs. >> >> I've added simple pledge of "stdio rpath proc exec": >> * stdio - for showing the notifications >> * rpath - for reading configuration >> * proc/exec - for running scripts based on notifications > > Several fixes: > - Makefile ordering. Please, folks, follow the order of > Makefile.template. A consistent order makes it much easier to review. > - $OpenBSD$ marker at the top of Makefile (portcheck will warn about > this) > - config.mk overwrites the optimization setting with -Os, this should be > patched out > - print compile commands (V=1) > - replace most of the Makefile/config.mk patch with MAKE_FLAGS; putting > dunstrc in the right place can be done in post-install > - err(3) needs err.h > - in notification.c, basename(3) should be declared, else the return > value (pointer) is truncated to int; harmful on LP64 > - regex tweaks: replace \b with [[:<:]], re-add "www.", no need to > escape "." within square brackets > - uses pledge() marker > > Updated tarball attached,
Ah, you have a lot of good points. Seems I need to read up on the porters guide some more. Timo
