On Tue, 23 Aug 2016 08:53:06 -0500, Amit Kulkarni <amitk...@gmail.com> wrote:
> > > > > SHARED_LIBS += sylph-0 3.0 # > > > 3.0 SHARED_LIBS += sylpheed-plugin-0 3.0 > > > # 3.0 > > > > I was surprised to see these not change between 3.4.x and 3.5.x, but > > indeed, shared-libs.log suggests they are correct. What do you > > think, do we trust upstream to have gotten this right? > > > > Other than that (potential red herring), this looks good to me. > > > Just for safety's sake, I bumped SHARED_LIBS to 4.0 If you follow the FAQ [1], you can see only symbols were added so a minor bump would be enough. That said, bumps are cheap so either a major or a minor bump is good. Minor nit, whatever you chose it should be SHARED_LIBS += sylph-0 4.0 # 3.0 SHARED_LIBS += sylpheed-plugin-0 4.0 # 3.0 or SHARED_LIBS += sylph-0 3.1 # 3.0 SHARED_LIBS += sylpheed-plugin-0 3.1 # 3.0 The value after the # indicates the value used by upstream. These lines can be retrieved from WRKBUILD/shared_libs.log Other than that, looks good ports-wise. ok danj@ with the nit [1] https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs Cheers, Daniel
