On Thu, Sep 01, 2016 at 04:27:19PM +0100, Edd Barrett wrote:
> On Thu, Sep 01, 2016 at 04:41:57PM +0200, Landry Breuil wrote:
> > edd, ok for both ?
>
> Starting with py-sqlparse:
>
> > # MIBSD
> > PERMIT_PACKAGE_CDROM = Yes
>
> Is MIBSD that a typo?
Yeah i wanted BSD only, typo.
> For new Python ports, I tend to add a Python3 FLAVOR, but I can do that
> as a later change if you want.
>
> There is a py.test test suite which 'make test' does not currently run.
> Add a TEST_DEPEND, and a do-test target which does:
>
> cd ${WRKSRC} && ${MODPY_BIN} -m pytest tests/
Ah, indeed. Fixed locally.
> You will need to check if the test suite needs the package installed,
> and if it does, add a self-TEST_DEPEND.
>
> Are you sure tox is needed?
That's what README.md and Makefile says..
Landry
