David Coppa <dco...@gmail.com> writes:
> On Wed, 07 Sep 2016, Jeremie Courreges-Anglas wrote:
>
>> Sol??ne Rapenne <sol...@perso.pw> writes:
>>
>> >> Updated port attached, which should fix this issue.
>> >>
>> >>>> There is a texinfo doc but I don't know what to do with it, it's not
>> >>>> included in the package.
>> >>>
>> >>> The install method provided by upstream properly installs the info
>> >>> page.
>> >>>
>> >>>> I didn't used ${INSTALL_PROGRAM} macro because after stripping the
>> >>>> binary, starting stumpwm would only start a vanilla sbcl (the binary
>> >>>> should be around 60 Mb and after stripping it's only 620 kb).
>> >>>
>> >>> Upstream doesn't use install -s by default.
>> >>>
>> >>> The trick is to get upstream's install target to put stuff in the
>> >>> right
>> >>> directory. Here, setting DESTDIRNAME=destdir is enough ('cause
>> >>> upstream
>> >>> uses a variable named 'destdir' instead of something more standard
>> >>> like
>> >>> 'DESTDIR')
>> >>>
>> >>> Updated version, with the following changes:
>> >>> - trim COMMENT
>> >>> - sbcl is a BUILD_DEPEND only
>> >>> - use the autoconf CONFIGURE_STYLE, which automatically adds the
>> >>> proper
>> >>> deps to BUILD_DEPENDS, drop the custom do-configure step
>> >>> - use the latest autoconf version
>> >>> - trim CONFIGURE_ARGS
>> >>> - set PORTHOME (required, as you already noticed)
>> >>> - use upstream's install target
>> >
>> > I made some little changes
>> >
>> > - Removed CONFIGURE_ARGS because --with-lisp=sbcl is the default
>> > upstream
>> > - Replaced spaces by tabs in Makefile
>> > - added to Makefile patch "--disable-debugger" parameter to sbcl so if
>> > the build fails sbcl exits with an error without starting the
>> > interactive debugger
>>
>> Looks fine to me.
>
> WANTLIB is missing:
>
> ---8<---
>
> --- Makefile.old
> +++ Makefile
> @@ -14,6 +14,8 @@
> # GPLv2
> PERMIT_PACKAGE_CDROM= Yes
>
> +WANTLIB= c m util
> +
> MASTER_SITES= https://github.com/stumpwm/stumpwm/archive/
> MASTER_SITES0= https://github.com/edicl/cl-ppcre/archive/
> MASTER_SITES1=
> http://beta.quicklisp.org/archive/clx/2016-08-25/
>
> ---8<---
Oops.
> With this, it's ok with me.
>
> Jeremie, please do the import if you want to.
Done, thanks.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
