On 11/05 11:48, Stuart Henderson wrote: > On 2016/11/04 14:06, Jeremy Evans wrote: > > Currently if you call portbump and the Makefile does not have REVISION > > set, it does nothing. That definitely was not what I expect, since a > > bump if REVISION is not set involves setting REVISION = 0. Other b2k16 > > attendees also agree. > > er, that does work for me already, check @_REV_NEIGHBORS >
Well, it doesn't work for me. Example with databases/ruby-sequel (which currently has no REVISION): cd /usr/ports infrastructure/bin/portbump databases/ruby-sequel cvs diff databases/ruby-sequel/Makefile # Without Patch: No Output # With Patch: Index: databases/ruby-sequel/Makefile =================================================================== RCS file: /cvs/ports/databases/ruby-sequel/Makefile,v retrieving revision 1.38 diff -u -p -r1.38 Makefile --- databases/ruby-sequel/Makefile 4 Nov 2016 21:30:02 -0000 1.38 +++ databases/ruby-sequel/Makefile 5 Nov 2016 22:15:42 -0000 @@ -3,6 +3,7 @@ COMMENT = lightweight database library and ORM for Ruby DISTNAME = sequel-4.40.0 +REVISION = 0 CATEGORIES = databases HOMEPAGE = http://sequel.jeremyevans.net/ Maybe the existing code works in some cases but not others, but it definitely doesn't handle all cases. It's likely there is a better fix than my approach. CCing zhuk@, maybe he could come up with a better solution. Thanks, Jeremy
