Giovanni Bechis <giova...@paclan.it> writes: > pkg/DESCR: > Digest::SHA is a complete implementation of the NIST Secure Hash > Standard. > It gives Perl programmers a convenient way to calculate > SHA-1, SHA-224, SHA-256, SHA-384, SHA-512, SHA-512/224, and SHA-512/256 > message digests. > The module can handle all types of input, including partial-byte data. > > Comments ? Ok ?
I see this on amd64: /usr/bin/perl /usr/libdata/perl5/ExtUtils/xsubpp -typemap /usr/libdata/perl5/ExtUtils/typemap -typemap typemap SHA.xs > SHA.xsc && mv SHA.xsc SHA.c cc -c -I. -DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -fstack-protector -I/usr/local/include -O2 -DVERSION=\"5.96\" -DXS_VERSION=\"5.96\" -DPIC -fPIC "-I/usr/libdata/perl5/amd64-openbsd/5.20.3/CORE" SHA.c In file included from SHA.xs:35: src/sha.c: In function 'sharewind': src/sha.c:297: warning: array size (32) smaller than bound length (64) src/sha.c:297: warning: array size (32) smaller than bound length (64) src/sha.c:298: warning: array size (32) smaller than bound length (64) src/sha.c:298: warning: array size (32) smaller than bound length (64) src/sha.c:299: warning: array size (32) smaller than bound length (64) src/sha.c:299: warning: array size (32) smaller than bound length (64) It doesn't *look* harmful but better fix it and give upstream a heads-up (-Wbounded is OpenBSD-only, afaik). Why the extra newlines in pkg/DESCR? Looks fine otherwise. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
