On Fri, Nov 25, 2016 at 06:49:35PM -0700, Andrew Fresh wrote: > On Fri, Nov 25, 2016 at 11:13:41PM +0100, Alexander Bluhm wrote: > > On Thu, Nov 24, 2016 at 01:07:03PM -0700, Andrew Fresh wrote: > > > devel/p5-namespace-autoclean fails tests both with and without these > > > changes. > > > > I am testing the Perl 5.24.1-RC4 update. With that it passes. > > Aha, for some reason it's missing the p5-Test-Requires hard requirement. > With this patch, more tests run and they all pass, even after > pkg_deleteing everything before `make test`.
Usually I do a 'grep use' in the t directory. Not all dependencies are recorded properly in various perl modules. I think you should add devel/p5-Sub-Install although it is currently installed by a transitive dependency. > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/devel/p5-namespace-autoclean/Makefile,v > retrieving revision 1.10 > diff -u -p -r1.10 Makefile > --- Makefile 20 Mar 2016 19:56:42 -0000 1.10 > +++ Makefile 25 Nov 2016 23:50:42 -0000 > @@ -20,4 +20,9 @@ RUN_DEPENDS = devel/p5-B-Hooks-EndOfScop > TEST_DEPENDS = devel/p5-Moose \ > devel/p5-Sub-Name The indentation is wrong here. Space vs. Tab > > +TEST_DEPENDS += devel/p5-Test-Requires \ > + devel/p5-Moo \ > + devel/p5-MooseX-Role-WithOverloading \ > + devel/p5-Mouse Why another TEST_DEPENDS += block? Can you put it in one? > + > .include <bsd.port.mk> anyway OK bluhm@
