On Sat, Jan 07, 2017 at 06:27:53PM +0100, Adam Wolk wrote: > On Sun, Jan 01, 2017 at 03:15:47PM +0100, Adam Wolk wrote: > > On Sun, Jan 01, 2017 at 03:02:10PM +0100, Antoine Jacoutot wrote: > > > On Sun, Jan 01, 2017 at 02:57:30PM +0100, Adam Wolk wrote: > > > > Hi ports@ > > > > > > > > Attaching a bump to devel/zeal > > > > > > > > port changes: > > > > - add x11/qt5/qt5base dependency to LIB_DEPENDS > > > > - add Qt5Concurrent to WANTLIB (from qtbase) > > > > - mark USE_WXNEEDED = Yes (uses qt webkit) > > > > > > Hmm, can't the qtwebkit port be patched like www/webkitgtk4 so that > > > pkg-config > > > files or whatever cmake magic pass the proper -Wl flags insead of adding > > > USE_WXNEEDED to all qtwebkit consumers? > > > > I just checked why www/otter-browser doesn't need it as a qtwebkit consumer > > and > > in that case devel/cmake was patched to pass the wx flags during the build. > > > > This port uses devel/qmake to build hence it doens't get the same automatic > > benefit. > > > > x11/qt5/qtwebkit/ has USE_WNEEDED = Yes in what way could it impact > > producing a > > downstream (consumer) binary that's also marked as wxneeded? > > > > > Also we usually put USE_WXNEEDED at the top of the Makefile. > > > > > > > > > > Will move that to the top of the file before comitting (assuming I will get > > an > > OK of course ;)). > > > > Regards, > > Adam > > > > Ping for reviews & a discussion on how to handle WXNEEDED with this port. >
Ping.
