On 2017/02/22 02:27, Jonathan Gray wrote:
> On Sun, Aug 28, 2016 at 09:05:18PM +0500, Alexandr Shadchin wrote:
> > On Sun, Aug 28, 2016 at 04:44:44PM +0200, Daniel Jakots wrote:
> > > On Sun, 28 Aug 2016 12:39:00 +0200, Daniel Jakots <danj+o...@chown.me>
> > > wrote:
> > >
> > > > Here's a diff to update to py-argcomplete-1.4.1.
> > >
> > > Now that it has been committed (thanks jca@), I can update and a py3
> > > flavor to devel/py-argh
> > >
> > > Comments? OK?
> > >
> >
> > ok shadchin@
>
> Here is a newer version, update-plist seemed unhelpful, looks like
> the existing PLIST is fine?
There are some additions,
bin/python-argcomplete-tcsh${MODPY_BIN_SUFFIX}
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
Tests are a bit messed up though, some missing deps - py-coverage, py-pexpect,
bash, tcsh we have - there's also devel/flake8 of which we only have a py2
version (and this was imported as just "flake8" rather than "py-flake8" so
adding a py3 flavour is going to be more fiddly than usual). It also uses
"wheel" which isn't in ports as far as I can see.
The do-test override isn't needed in this version, the default test target
gives much more information about failures. But it does need "python" to be
in the path, it can't cope with "python2.7".
Also I see it runs out of PTYs during tests unless I create more device
nodes.
So here's a better-but-not-perfect diff..
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/py-argcomplete/Makefile,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile
--- Makefile 3 Jan 2017 19:19:48 -0000 1.7
+++ Makefile 21 Feb 2017 16:10:39 -0000
@@ -2,11 +2,10 @@
COMMENT = bash tab completion for argparse
-MODPY_EGG_VERSION = 1.4.1
+MODPY_EGG_VERSION = 1.8.2
DISTNAME = argcomplete-${MODPY_EGG_VERSION}
PKGNAME = py-${DISTNAME}
CATEGORIES = devel
-REVISION = 0
# GPLv3+
PERMIT_PACKAGE_CDROM= Yes
@@ -19,12 +18,22 @@ MODPY_SETUPTOOLS = Yes
FLAVORS = python3
FLAVOR ?=
+# XXX flake8 needs renaming before adding py3 support to it
+# also wants wheel, not yet ported
+TEST_DEPENDS = devel/py-coverage${MODPY_FLAVOR} \
+ devel/py-pexpect${MODPY_FLAVOR} \
+ devel/flake8 \
+ shells/bash \
+ shells/tcsh
+
post-install:
for i in ${PREFIX}/bin/*; do \
mv $${i} $${i}${MODPY_BIN_SUFFIX} ;\
done
-do-test:
- cd ${WRKSRC}/test && ${MODPY_BIN} test.py
+pre-test:
+ @ln -fs ${MODPY_BIN} ${WRKDIR}/bin/python
+ @[[ -r /dev/ptyz0 ]] || (printf "\\nWARNING: tests are likely to fail\
+ unless additional ptys are available.\\n\\n" >&2; sleep 2)
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/py-argcomplete/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 28 Aug 2016 10:55:38 -0000 1.3
+++ distinfo 21 Feb 2017 16:10:39 -0000
@@ -1,2 +1,2 @@
-SHA256 (argcomplete-1.4.1.tar.gz) =
p7X6jRrLaeSbPGs/YiW8cJCS4Mf2ITEbrFB6T27+YJ0=
-SIZE (argcomplete-1.4.1.tar.gz) = 37219
+SHA256 (argcomplete-1.8.2.tar.gz) =
eizN4HTrZjEjKy+R+NjVmF1b6/DjawkREwluOgOFVGs=
+SIZE (argcomplete-1.8.2.tar.gz) = 53626
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/py-argcomplete/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -r1.2 PLIST
--- pkg/PLIST 28 Aug 2016 10:55:38 -0000 1.2
+++ pkg/PLIST 21 Feb 2017 16:10:39 -0000
@@ -1,6 +1,7 @@
@comment $OpenBSD: PLIST,v 1.2 2016/08/28 10:55:38 danj Exp $
bin/activate-global-python-argcomplete${MODPY_BIN_SUFFIX}
bin/python-argcomplete-check-easy-install-script${MODPY_BIN_SUFFIX}
+bin/python-argcomplete-tcsh${MODPY_BIN_SUFFIX}
bin/register-python-argcomplete${MODPY_BIN_SUFFIX}
lib/python${MODPY_VERSION}/site-packages/argcomplete/
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/
@@ -8,6 +9,7 @@ lib/python${MODPY_VERSION}/site-packages
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/SOURCES.txt
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/not-zip-safe
+lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/requires.txt
lib/python${MODPY_VERSION}/site-packages/argcomplete-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
lib/python${MODPY_VERSION}/site-packages/argcomplete/__init__.py
${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/argcomplete/${MODPY_PYCACHE}/
