Ignore what I said, depends on version the ExtUtils::MakeMaker if
Module::Build is used or not. Removes later on in the Makefile.PL if not
needed. It's some form of fix up for old versions, either generated by
Dist::Zilla or hand crafted into the generated files, as present before
Dist::Zilla was used.

On 03/22/17 21:46, Andrew Fresh wrote:
> On Wed, Mar 22, 2017 at 08:37:32PM +0000, Nigel Taylor wrote:
>> On 03/22/17 08:37, Giannis Tsaraias wrote:
>>> Hi,
>>>
>>> Update to 1.20170117. Changed the license string to 'Perl', which is
>>> what it uses. Passes test suite.
>>>
>>> OK?
>>>
> <SNIP> 
>> I have a number of update for Perl 5.24, this is one.
>>
>> Your build most likely works because of other perl modules being built.
>> If you look at the Makefile.PL and Build.PL you will see it using
>> Module::Build, which means modbuild style should have been used, that
>> will ensure p5-Module-Build gets installed.
> 
> I don't quite follow.  The Makefile.PL I see was built with dist-zilla
> and the MakeMaker Plugin:
> 
> https://metacpan.org/pod/Dist::Zilla::Plugin::MakeMaker
> 
> The actual repo doesn't have either a Build.PL or a Makefile.PL, they
> are both generated files and so both should be equally valid.
> 
> https://github.com/chromatic/Modern-Perl
> 
> 
>> This should have the following change:-
>  
> I don't see why it is needed, I can build and install the package
> without having Module::Build.
> 
>> Index: Makefile
>> ===================================================================
>> RCS file: /home/cvs/ports/devel/p5-Modern-Perl/Makefile,v
>> retrieving revision 1.3
>> diff -u -p -r1.3 Makefile
>> --- Makefile    20 Mar 2016 19:56:27 -0000      1.3
>> +++ Makefile    20 Mar 2016 23:19:34 -0000
>> @@ -13,6 +13,8 @@ MAINTAINER =          Edward <[email protected]>
>>  # The Artistic License 1.0
>>  PERMIT_PACKAGE_CDROM = Yes
>>
>> +CONFIGURE_STYLE =      modbuild
>> +
>>  post-install:
>>         ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/p5-Modern-Perl
>>         ${INSTALL_DATA} \
> 
> l8rZ,
> 

Reply via email to