On 2017/04/18 12:36, Rafael Sadowski wrote:
> On Fri Apr 14, 2017 at 09:48:55AM +0100, Stuart Henderson wrote:
> > Iirc our cmake creates files with .so and no version if you don't specify
> > SHARED_LIBS. Try setting that for the shared libraries name (version 0.0)
> > and rebuild/regen plist.
> > >
> > > Is this a module, or a shared library? The cmake config seems to
> > > specify a library, but doesn't specify a version.
> > >
> > > If it should be installed, it should have a version. Something like:
> > >
> > > SHARED_LIBS = slopy 0.0 # ?
> > >
> > > > +@man man/man1/slop.1
> > >
>
> Sorry, totally overlooked. New diff should be fine. Please, also look at
> the maim diff too.
Same comment as for maim with DISTNAME / V / GH_TAGNAME. Otherwise ok.
> ===================================================================
> RCS file: /cvs/ports/graphics/slop/Makefile,v
> retrieving revision 1.10
> diff -u -p -u -p -r1.10 Makefile
> --- Makefile 10 Apr 2017 11:46:21 -0000 1.10
> +++ Makefile 18 Apr 2017 10:06:01 -0000
> @@ -1,21 +1,33 @@
> # $OpenBSD: Makefile,v 1.10 2017/04/10 11:46:21 sthen Exp $
>
> -V = 4.1.16
> +V = 5.3.37
> COMMENT = query for a selection and print to stdout (select operation)
> DISTNAME = slop-${V}
> CATEGORIES = graphics x11
> -REVISION = 0
>
> GH_ACCOUNT = naelstrof
> GH_PROJECT = slop
> GH_TAGNAME = v${V}
>
> +SHARED_LIBS = slopy 0.0 # 0.0
> +
> +MAINTAINER = Rafael Sadowski <rsadow...@openbsd.org>
> +
> # GPLv3+
> PERMIT_PACKAGE_CDROM = Yes
>
> -WANTLIB += ICE SM X11 Xext c m ${LIBCXX}
> +WANTLIB += GL GLU ICE SM X11 Xext Xrender c m pthread ${LIBCXX}
> +
> +MODULES = devel/cmake \
> + gcc4
> +
> +MODGCC4_LANGS = c++
> +MODGCC4_ARCHS = ${GCC3_ARCHS} ${GCC4_ARCHS}
> +
> +BUILD_DEPENDS += graphics/glm
>
> -MODULES = devel/cmake
> +CONFIGURE_ARGS += -DCMAKE_INSTALL_MANDIR="${LOCALBASE}/man" \
> + -DCMAKE_COMPRESS_MAN:BOOL=Off
>
> NO_TEST = Yes
>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/graphics/slop/distinfo,v
> retrieving revision 1.5
> diff -u -p -u -p -r1.5 distinfo
> --- distinfo 21 Apr 2015 02:07:38 -0000 1.5
> +++ distinfo 18 Apr 2017 10:06:01 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (slop-4.1.16.tar.gz) = wp8MzbKLxYfJFOmfo/qgmyE129UZp1thSP2kLEFX6Rg=
> -SIZE (slop-4.1.16.tar.gz) = 35997
> +SHA256 (slop-5.3.37.tar.gz) = OhZW+MzFOrWixv/glYk7Bc9Qo7pdM4V+z0jOP0SAUdw=
> +SIZE (slop-5.3.37.tar.gz) = 68182
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/graphics/slop/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 16 Nov 2014 16:48:56 -0000 1.1.1.1
> +++ pkg/PLIST 18 Apr 2017 10:06:01 -0000
> @@ -1,2 +1,5 @@
> @comment $OpenBSD: PLIST,v 1.1.1.1 2014/11/16 16:48:56 bcallah Exp $
> @bin bin/slop
> +include/slop.hpp
> +@lib lib/libslopy.so.${LIBslopy_VERSION}
> +@man man/man1/slop.1
>
